-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to check compatibility #8486
Add workflow to check compatibility #8486
Conversation
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Hi @nknize This PR is ready for review. Please let me know if it needs any changes. Thanks! |
I looked at gaiksaya#7 (comment) and it outputs this.
It tells me what's "incompatible" (I suppose it means it didn't build), but doesn't really give me anything actionable like a log, or a reason. What is one supposed to do when they see an error from this check? |
The log or reason can be viewed on the workflow itself: https://github.com/gaiksaya/OpenSearch/actions/runs/5472486309/job/14817298994 Regarding action item, that is next in queue to create GitHub issues in respective component repo once the concerned PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving forward with this PR. |
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> (cherry picked from commit 85f918e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 85f918e) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
All the issues linked here confirmed that all plugins have passing
gradle assemble
andmavenlocal()
as their first repository in build.gradle are closed now: opensearch-project/opensearch-devops#114Description
This change adds a workflow to check the compatibility with all the plugins in opensearch-project. It adds a comment if any component is incompatible. Example: gaiksaya#7 (comment)
Related Issues
opensearch-project/opensearch-devops#114
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.