Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to check compatibility #8486

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Jul 6, 2023

All the issues linked here confirmed that all plugins have passing gradle assemble and mavenlocal() as their first repository in build.gradle are closed now: opensearch-project/opensearch-devops#114

Description

This change adds a workflow to check the compatibility with all the plugins in opensearch-project. It adds a comment if any component is incompatible. Example: gaiksaya#7 (comment)

Related Issues

opensearch-project/opensearch-devops#114

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

gaiksaya added 2 commits July 6, 2023 05:39
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

@gaiksaya
Copy link
Member Author

Hi @nknize This PR is ready for review. Please let me know if it needs any changes. Thanks!

@dblock
Copy link
Member

dblock commented Jul 27, 2023

I looked at gaiksaya#7 (comment) and it outputs this.

> Task :test:external-modules:test-delayed-aggs:publishNebulaPublicationToMavenLocal
> Task :test:external-modules:test-delayed-aggs:publishToMavenLocal
> Task :checkCompatibility
Compatible components: [https://github.com/opensearch-project/common-utils]

It tells me what's "incompatible" (I suppose it means it didn't build), but doesn't really give me anything actionable like a log, or a reason. What is one supposed to do when they see an error from this check?

@gaiksaya
Copy link
Member Author

I looked at gaiksaya#7 (comment) and it outputs this.

> Task :test:external-modules:test-delayed-aggs:publishNebulaPublicationToMavenLocal
> Task :test:external-modules:test-delayed-aggs:publishToMavenLocal
> Task :checkCompatibility
Compatible components: [https://github.com/opensearch-project/common-utils]

It tells me what's "incompatible" (I suppose it means it didn't build), but doesn't really give me anything actionable like a log, or a reason. What is one supposed to do when they see an error from this check?

The log or reason can be viewed on the workflow itself: https://github.com/gaiksaya/OpenSearch/actions/runs/5472486309/job/14817298994

Regarding action item, that is next in queue to create GitHub issues in respective component repo once the concerned PR is merged.

@bbarani
Copy link
Member

bbarani commented Aug 1, 2023

@dblock @gaiksaya @nknize Whats the next steps to get this PR merged?

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the next steps to get this PR merged?

I missed this notification sorry for the delay. I'm +1 this PR. It will greatly help me prioritize backports. Thanks @bbarani and @gaiksaya!

@gaiksaya
Copy link
Member Author

gaiksaya commented Aug 1, 2023

Moving forward with this PR.
Will monitor if this change is working as intended. If it is, the next step as stated above will be creating GH issues in all incompatible components repositories when the pull request breaking things is merged in this repository.
Thanks!

@gaiksaya gaiksaya merged commit 85f918e into opensearch-project:main Aug 1, 2023
@gaiksaya gaiksaya deleted the comp-check-workflow branch August 1, 2023 22:27
@gaiksaya gaiksaya added the backport 2.x Backport to 2.x branch label Aug 2, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2023
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
(cherry picked from commit 85f918e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Aug 2, 2023
(cherry picked from commit 85f918e)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants