Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend existing IndexRecoveryIT for remote indexes #8505

Merged
merged 7 commits into from
Jul 10, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Jul 6, 2023

Description

Add integration tests for recovery flow for remote enabled indexes by extending existing recovery indexing integ tests.

Related Issues

Resolves #8476 and #8485

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocationWithSegRepFailure

Copy link
Collaborator

@gbbafna gbbafna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since slowDownRecovery doesn't work for remote backed indices, we won't be getting much value from the tests at this point of time . can we please override this function in RemoteReindexRecovery and add a backlog item to control the recovery speed for remote backed indices ?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #8505 (24827ef) into main (9fd1ddb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 24827ef differs from pull request most recent head d1cd823. Consider uploading reports for the commit d1cd823 to get more accurate results

@@             Coverage Diff              @@
##               main    #8505      +/-   ##
============================================
- Coverage     70.90%   70.89%   -0.01%     
- Complexity    56961    56973      +12     
============================================
  Files          4758     4758              
  Lines        269362   269363       +1     
  Branches      39408    39409       +1     
============================================
- Hits         190980   190964      -16     
- Misses        62249    62301      +52     
+ Partials      16133    16098      -35     
Impacted Files Coverage Δ
...n/java/org/opensearch/index/engine/NoOpEngine.java 62.66% <0.00%> (-2.20%) ⬇️

... and 439 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.gateway.RecoveryFromGatewayIT.testReuseInFileBasedPeerRecovery

@ashking94
Copy link
Member Author

The ITs added as part of this PR have been run successfully for 200 iterations.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.testDropPrimaryDuringReplication

@gbbafna gbbafna merged commit 6d39aaa into opensearch-project:main Jul 10, 2023
@gbbafna gbbafna deleted the 8476 branch July 10, 2023 13:54
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jul 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 10, 2023
Signed-off-by: Ashish Singh <ssashish@amazon.com>
(cherry picked from commit 6d39aaa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Jul 10, 2023
(cherry picked from commit 6d39aaa)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…t#8505)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…t#8505)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog Storage:Durability Issues and PRs related to the durability framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remote Store] Add integration tests for recovery flow
3 participants