-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snapshot Interop] Keep API parameters behind remote store experiment… #8594
Conversation
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/snapshots/RestoreService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/opensearch/action/admin/cluster/snapshots/restore/RestoreSnapshotRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/RepositoriesService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/snapshots/SnapshotInfo.java
Outdated
Show resolved
Hide resolved
0a19e83
to
4b10185
Compare
Do we really need these changes ? It might be okay showing some extra flags in API output as it wouldn't break the clients. |
Gradle Check (Jenkins) Run Completed with:
|
4b10185
to
971b559
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's create a tracking doc change for the new flag in create snapshot response.
Gradle Check (Jenkins) Run Completed with:
|
971b559
to
75f1dd3
Compare
…al flag. Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
75f1dd3
to
84f86bb
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Failing tests are not related to this change and are flaky . Merging it as it is important to block interop related params when remote store is not enabled . |
…al flag. (opensearch-project#8594) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
…al flag. (opensearch-project#8594) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
…al flag. (opensearch-project#8594) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
…al flag. (opensearch-project#8594) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
…al flag. (opensearch-project#8594) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
…al flag. (opensearch-project#8594) Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
…al feature flag.
Description
Documentation Changes for Snapshot Interop Project are still not merged.
We will be launching Snapshot Interop Feature with Remote Store Feature, so as part of this PR we are keeping all the Snapshot Interop related API parameters behind the Remote Store Feature Flag.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.