[Search Pipeline] Flip SEARCH_PIPELINE feature flag for Search Pipeline GA

[noCharger]

Description

Flip the feature flag as described in #8513 (comment)

Related Issues

#8489

Check List

• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/19800/
• CommitID: 5c1974c

[codecov]

Codecov Report

Merging #8613 (5c1974c) into main (a430e18) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 5c1974c differs from pull request most recent head 20314ad. Consider uploading reports for the commit 20314ad to get more accurate results

@@             Coverage Diff              @@
##               main    #8613      +/-   ##
============================================
+ Coverage     70.87%   70.91%   +0.04%     
+ Complexity    56962    56956       -6     
============================================
  Files          4758     4758              
  Lines        269510   269417      -93     
  Branches      39446    39420      -26     
============================================
+ Hits         191005   191053      +48     
+ Misses        62440    62318     -122     
+ Partials      16065    16046      -19     

Impacted Files	Coverage Δ
.../java/org/opensearch/common/util/FeatureFlags.java	92.30% <100.00%> (ø)

... and 448 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      2 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessAfterFailureInFirstAttemptAfterSnapshotAndMetadataUpload
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes

• URL: https://build.ci.opensearch.org/job/gradle-check/19825/
• CommitID: 19dc105
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/19826/
• CommitID: 20314ad

[reta]

@noCharger we need to update the documentation for this feature [1], could you please create an issue there? thank you

[1] https://github.com/opensearch-project/documentation-website/tree/main/_search-plugins/search-pipelines

[reta]

Flaky tests failures from #8131

[reta]

Precommit crashes JVM on Windows (twice):

Exec output and error:
> Task :modules:reindex:jarHell FAILED
| Output for C:\hostedtoolcache\windows\Java_Adopt_jdk\11.0.19-7\x64\bin\java.exe:OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x0000000090000000, 117440512, 0) failed; error='The paging file is too small for this operation to complete' (DOS error/errno=1455)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 117440512 bytes for Failed to commit area from 0x0000000090000000 to 0x0000000097000000 of length 117440512.
# An error report file with more information is saved as:
# D:\a\OpenSearch\OpenSearch\modules\reindex\hs_err_pid7140.log

 JVM crash log found: file:///D:/a/OpenSearch/OpenSearch/hs_err_pid5260.log

[noCharger]

@noCharger we need to update the documentation for this feature [1], could you please create an issue there? thank you

[1] https://github.com/opensearch-project/documentation-website/tree/main/_search-plugins/search-pipelines

@reta Issue created, thanks!

Existing one opensearch-project/documentation-website#4502

[reta]

@msfroh looks good to you?

[noCharger]

@msfroh @andrross need more eyes on this PR. Thanks!

[stephen-crawford]

Looks good. This can be merged.

[macohen]

@reta are you able to merge, please? any other concerns or need for @andrross to take a look?

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8613-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 051550112c7ae7ae1e81f9da3eff10c73407cf38
# Push it to GitHub
git push --set-upstream origin backport/backport-8613-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8613-to-2.x.