Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry exporter config #8624

Merged
merged 18 commits into from
Jul 12, 2023

Conversation

Gaganjuneja
Copy link
Contributor

@Gaganjuneja Gaganjuneja commented Jul 11, 2023

Description

Make SpanExporter configurable. Users need to provide the provider to create SpanExporter. Already added the provider for LoggingSpanExporter.

Related Issues

Resolves #8620

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gagan Juneja added 4 commits July 11, 2023 16:43
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@Gaganjuneja
Copy link
Contributor Author

@reta, Please take a look.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.SnapshotStatusApisIT.testStatusAPICallForShallowCopySnapshot
      1 org.opensearch.snapshots.SnapshotStatusApisIT.testCorrectCountsForDoneShards

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #8624 (a9193b3) into main (3d7d33b) will increase coverage by 0.09%.
The diff coverage is 82.85%.

@@             Coverage Diff              @@
##               main    #8624      +/-   ##
============================================
+ Coverage     70.76%   70.85%   +0.09%     
- Complexity    56921    56971      +50     
============================================
  Files          4759     4761       +2     
  Lines        269676   269705      +29     
  Branches      39451    39452       +1     
============================================
+ Hits         190833   191097     +264     
+ Misses        62717    62439     -278     
- Partials      16126    16169      +43     
Impacted Files Coverage Δ
...etry/tracing/exporter/OTelSpanExporterFactory.java 71.42% <71.42%> (ø)
.../org/opensearch/telemetry/OTelTelemetryPlugin.java 100.00% <100.00%> (ø)
...rg/opensearch/telemetry/OTelTelemetrySettings.java 100.00% <100.00%> (ø)
...search/telemetry/tracing/OTelResourceProvider.java 100.00% <100.00%> (ø)

... and 464 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@Gaganjuneja
Copy link
Contributor Author

@reta, committed the suggested changes.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithInvokeFlush
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

Gagan Juneja added 2 commits July 12, 2023 17:48
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit c71c7d1 into opensearch-project:main Jul 12, 2023
@reta reta added the backport 2.x Backport to 2.x branch label Jul 12, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8624-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c71c7d1be845c99b2471c5674bc2f208f2ca8ef2
# Push it to GitHub
git push --set-upstream origin backport/backport-8624-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8624-to-2.x.

@reta
Copy link
Collaborator

reta commented Jul 12, 2023

:( @Gaganjuneja could you please manually backport to 2.x? thank you

dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add logs for successful instantiation

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add logs for successful instantiation

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add logs for successful instantiation

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Makes exporter configurable

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add logs for successful instantiation

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Move settings to OtelTelemetrySettings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* refactor

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracing Framework] Make SpanExporter configurable
2 participants