-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry exporter config #8624
Telemetry exporter config #8624
Conversation
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@reta, Please take a look. |
...metry-otel/src/main/java/org/opensearch/telemetry/tracing/exporter/SpanExporterProvider.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8624 +/- ##
============================================
+ Coverage 70.76% 70.85% +0.09%
- Complexity 56921 56971 +50
============================================
Files 4759 4761 +2
Lines 269676 269705 +29
Branches 39451 39452 +1
============================================
+ Hits 190833 191097 +264
+ Misses 62717 62439 -278
- Partials 16126 16169 +43
|
Gradle Check (Jenkins) Run Completed with:
|
plugins/telemetry-otel/src/test/java/org/opensearch/telemetry/OTelTelemetryPluginTests.java
Outdated
Show resolved
Hide resolved
plugins/telemetry-otel/src/main/java/org/opensearch/telemetry/OtelTelemetrySettings.java
Outdated
Show resolved
Hide resolved
plugins/telemetry-otel/src/main/java/org/opensearch/telemetry/OtelTelemetrySettings.java
Outdated
Show resolved
Hide resolved
@reta, committed the suggested changes. |
Gradle Check (Jenkins) Run Completed with:
|
plugins/telemetry-otel/src/main/java/org/opensearch/telemetry/tracing/OTelResourceProvider.java
Show resolved
Hide resolved
...emetry-otel/src/main/java/org/opensearch/telemetry/tracing/exporter/SpanExporterFactory.java
Outdated
Show resolved
Hide resolved
plugins/telemetry-otel/src/main/java/org/opensearch/telemetry/OtelTelemetrySettings.java
Outdated
Show resolved
Hide resolved
...emetry-otel/src/main/java/org/opensearch/telemetry/tracing/exporter/SpanExporterFactory.java
Outdated
Show resolved
Hide resolved
...emetry-otel/src/main/java/org/opensearch/telemetry/tracing/exporter/SpanExporterFactory.java
Outdated
Show resolved
Hide resolved
...emetry-otel/src/main/java/org/opensearch/telemetry/tracing/exporter/SpanExporterFactory.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8624-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c71c7d1be845c99b2471c5674bc2f208f2ca8ef2
# Push it to GitHub
git push --set-upstream origin backport/backport-8624-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
:( @Gaganjuneja could you please manually backport to |
* Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add logs for successful instantiation Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fix test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fix test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
* Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add logs for successful instantiation Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fix test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fix test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
* Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add logs for successful instantiation Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fix test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fix test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
* Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Makes exporter configurable Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add logs for successful instantiation Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Move settings to OtelTelemetrySettings Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fix test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fix test cases Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * refactor Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Make SpanExporter configurable. Users need to provide the provider to create SpanExporter. Already added the provider for LoggingSpanExporter.
Related Issues
Resolves #8620
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.