[Segment Replication] [Revert] Remove Restriction of strictly using only docrep for system indices and hidden indices (#8502) #8657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rishikesh1159
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
…ndices and hidden indices. (opensearch-project#8502)" This reverts commit ef4881f. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Rishikesh1159
force-pushed
the
revert-8200
branch
from
fc69ed2
to
e3b64c5
Compare
Gradle Check (Jenkins) Run Completed with:
|
Rishikesh1159
added
skip-changelog
v2.9.0
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.9 #8657 +/- ##
============================================
- Coverage 71.05% 70.54% -0.51%
+ Complexity 57461 57080 -381
============================================
Files 4745 4745
Lines 270757 270765 +8
Branches 39961 39963 +2
============================================
- Hits 192390 191020 -1370
- Misses 62154 63319 +1165
- Partials 16213 16426 +213
|
mch2
approved these changes
Jul 12, 2023
kotwanikunal
approved these changes
Jul 12, 2023
|
Do we need to backport this to 2.9? NVM. Just saw the target branch. |
r1walz
pushed a commit
to r1walz/OpenSearch
that referenced
this pull request
Jul 13, 2023
…ndices and hidden indices. (opensearch-project#8502)" (opensearch-project#8657) This reverts commit ef4881f. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ef4881f.
Description
This reverts PR #8502 in 2.9 branch, as it might impact plugins with system indices
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.