Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Do not trigger storeDirectory.sync in segment download flow from remote store #8739

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Jul 18, 2023

Description

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…te store

Signed-off-by: Sachin Kale <kalsac@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.index.IndexSettingsTests.testDefaultSearchPipelineWithoutFeatureFlag

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #8739 (98c364d) into main (164fbb1) will increase coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8739      +/-   ##
============================================
+ Coverage     70.79%   71.01%   +0.21%     
- Complexity    57117    57231     +114     
============================================
  Files          4770     4770              
  Lines        270223   270222       -1     
  Branches      39493    39493              
============================================
+ Hits         191302   191893     +591     
+ Misses        62775    62145     -630     
- Partials      16146    16184      +38     
Impacted Files Coverage Δ
...in/java/org/opensearch/index/shard/IndexShard.java 69.58% <ø> (+0.46%) ⬆️

... and 489 files with indirect coverage changes

@sachinpkale sachinpkale merged commit 88d3ccd into opensearch-project:main Jul 18, 2023
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Jul 18, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 18, 2023
…te store (#8739)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
(cherry picked from commit 88d3ccd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Bukhtawar pushed a commit that referenced this pull request Jul 18, 2023
…te store (#8739) (#8743)

Do not trigger storeDirectory.sync in segment download flow from remote store

Signed-off-by: Sachin Kale <kalsac@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…te store (opensearch-project#8739)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…te store (opensearch-project#8739)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…te store (opensearch-project#8739)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants