Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix flaky test SegmentReplicationRemoteStoreIT.testPressureServiceStats #8855

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[Backport 2.x] Fix flaky test SegmentReplicationRemoteStoreIT.testPressureServiceStats #8855

merged 1 commit into from
Jul 25, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a3baa68 from #8827.

@github-actions
Fix flaky test SegmentReplicationRemoteStoreIT.testPressureServiceSta…
22eb930 
…ts (#8827)

* Fix ReplicationTracker to not include unavailable former primary shards when computing replication stats.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Fix relocation IT relying on stats to determine if segrep has occured. The API should still show a result for the replica even if it has not sync'd.

Signed-off-by: Marc Handalian <handalm@amazon.com>

---------

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit a3baa68)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member

mch2 commented Jul 24, 2023

Something is a little strange here - https://build.ci.opensearch.org/job/gradle-check/20862/ is still running without any failure.

@mch2
Copy link
Member

mch2 commented Jul 25, 2023

Odd - https://build.ci.opensearch.org/job/gradle-check/20862/ passed as UNSTABLE with:
#7643 failing.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member

dreamer-89 commented Jul 25, 2023 •
edited
Loading

Gradle Check (Jenkins) Run Completed with:

Known flaky test failures. Retrying gradle check.

  1. testPitCreatedOnReplica - [BUG] org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPitCreatedOnReplica is flaky #8850
  2. testStrictWeightedRoutingWithCustomString - [BUG] org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString is flaky #8030
org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness
 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPitCreatedOnReplica
 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPitCreatedOnReplica
 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPitCreatedOnReplica
 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPitCreatedOnReplica
 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testReplicationAfterForceMerge
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPrimaryStopped_ReplicaPromoted
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPitCreatedOnReplica
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #8855 (22eb930) into 2.x (cd71131) will decrease coverage by 0.12%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##                2.x    #8855      +/-   ##
============================================
- Coverage     70.74%   70.63%   -0.12%     
+ Complexity    57312    57282      -30     
============================================
  Files          4744     4744              
  Lines        271040   271050      +10     
  Branches      39972    39976       +4     
============================================
- Hits         191751   191456     -295     
- Misses        62850    63149     +299     
- Partials      16439    16445       +6
Files Changed Coverage Δ
...org/opensearch/index/seqno/ReplicationTracker.java 68.45% <74.07%> (+0.27%) ⬆️
.../replication/checkpoint/ReplicationCheckpoint.java 87.71% <100.00%> (+2.00%) ⬆️

... and 439 files with indirect coverage changes

@mch2 mch2 merged commit b442eb4 into 2.x Jul 25, 2023
10 of 34 checks passed
@mch2 mch2 deleted the backport/backport-8827-to-2.x branch July 25, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamer-89 dreamer-89 dreamer-89 approved these changes

@Poojita-Raj Poojita-Raj Poojita-Raj approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mch2 @dreamer-89 @Poojita-Raj