Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Add metadata prefix to Remote Translog Metadata file #8914

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Jul 27, 2023

Description

Added metadata prefix to remote translog metadata files. This serves two purpose

  1. Follow convention used in Remote Segment Store metadata .
  2. Ignore the extra files which can generated by different OS.

Related Issues

#8834

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi
Copy link
Collaborator

linuxpi commented Jul 27, 2023

LGTM. 1 minor comment

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Collaborator Author

gbbafna commented Jul 27, 2023

* What went wrong:
Execution failed for task ':distribution:bwc:staged:buildBwcLinuxTar'.
> Building 2.9.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/staged/build/bwc/checkout-2.9/distribution/archives/linux-tar/build/distributions/opensearch-min-2.9.0-SNAPSHOT-linux-x64.tar.gz

I am getting gradle failures despite retries. All the tests are passing . Looks like there is some issue with jenkins .

@linuxpi
Copy link
Collaborator

linuxpi commented Jul 27, 2023

seeing similar failure here - #8812

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Collaborator Author

gbbafna commented Jul 28, 2023

Failing tests are both flaky and are passing locally

    org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates
    org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

#8932
#6124

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      3 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #8914 (73e69d0) into main (3952d5e) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #8914   +/-   ##
=========================================
  Coverage     71.12%   71.12%           
- Complexity    57212    57256   +44     
=========================================
  Files          4759     4759           
  Lines        269881   269881           
  Branches      39488    39488           
=========================================
+ Hits         191943   191948    +5     
- Misses        61752    61754    +2     
+ Partials      16186    16179    -7     
Files Changed Coverage Δ
...ex/translog/transfer/TranslogTransferMetadata.java 84.61% <ø> (ø)
...ex/translog/transfer/BlobStoreTransferService.java 88.88% <100.00%> (ø)
...dex/translog/transfer/TranslogTransferManager.java 77.94% <100.00%> (ø)

... and 453 files with indirect coverage changes

@gbbafna gbbafna merged commit 96630f0 into opensearch-project:main Jul 28, 2023
9 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jul 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 28, 2023
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit 96630f0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Jul 28, 2023
(cherry picked from commit 96630f0)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 28, 2023
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…ect#8914)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…ect#8914)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ect#8914)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants