Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmute test SegmentReplicationIndexShardTests#testNRTReplicaWithRemot… #8931

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

Poojita-Raj
Copy link
Contributor

@Poojita-Raj Poojita-Raj commented Jul 27, 2023

…eStorePromotedAsPrimaryCommitCommit

Description

This test was muted in #8818 due to a pending backport of #8753 as mentioned in #8817.

Backport is complete now, and this test was run 500 times on main and 2.x branches successfully. Can now unmute the test safely.

Related Issues

Resolves #8817

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…eStorePromotedAsPrimaryCommitCommit

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/21137/

* **CommitID:** [53e277f](https://github.com/opensearch-project/OpenSearch/commit/53e277f45b0478ebde01325be30eced172cd15c6)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

Flaky: #8213

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/21173/

* **CommitID:** [53e277f](https://github.com/opensearch-project/OpenSearch/commit/53e277f45b0478ebde01325be30eced172cd15c6)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

#8213

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      3 org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates
      1 org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testShardAlreadyReplicating

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #8931 (53e277f) into main (91bc891) will decrease coverage by 0.09%.
Report is 15 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8931      +/-   ##
============================================
- Coverage     71.05%   70.96%   -0.09%     
+ Complexity    57198    57156      -42     
============================================
  Files          4758     4758              
  Lines        269863   269863              
  Branches      39484    39484              
============================================
- Hits         191755   191517     -238     
- Misses        61982    62219     +237     
- Partials      16126    16127       +1     

see 475 files with indirect coverage changes

@Rishikesh1159 Rishikesh1159 merged commit 883559c into opensearch-project:main Jul 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 28, 2023
…eStorePromotedAsPrimaryCommitCommit (#8931)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
(cherry picked from commit 883559c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 28, 2023
…eStorePromotedAsPrimaryCommitCommit (opensearch-project#8931)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Return 409 Conflict HTTP status instead of 500 on failure to concurrently execute snapshots

Signed-off-by: Mani <singh.mani1231@gmail.com>
andrross pushed a commit that referenced this pull request Jul 28, 2023
…eStorePromotedAsPrimaryCommitCommit (#8931) (#8981)

(cherry picked from commit 883559c)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…eStorePromotedAsPrimaryCommitCommit (opensearch-project#8931)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Return 409 Conflict HTTP status instead of 500 on failure to concurrently execute snapshots

Signed-off-by: Mani <singh.mani1231@gmail.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…eStorePromotedAsPrimaryCommitCommit (opensearch-project#8931)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…eStorePromotedAsPrimaryCommitCommit (opensearch-project#8931)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…eStorePromotedAsPrimaryCommitCommit (opensearch-project#8931)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix SegmentReplicationIndexShardTests#testNRTReplicaWithRemoteStorePromotedAsPrimaryCommitCommit
2 participants