Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] MediaTypeParserRegistry to MediaTypeRegistry #8940

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jul 27, 2023

Coming out of #8826 (comment), this PR rote refactors MediaTypeParserRegistry to MediaTypeRegistry to make the class naming align with the intention of the logic. The MediaTypeRegistry is a mechanism for downstream extensions to register concrete MediaTypes thus having "Parser" in the name is unneeded.

relates #5910
relates #8110

This commit rote refactors MediaTypeParserRegistry to MediaTypeRegistry
to make the class naming align with the intention of the logic. The
MediaTypeRegistry is a mechanism for downstream extensions to register
concrete MediaTypes thus having Parser in the name is unneeded.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added the pending backport Identifies an issue or PR that still needs to be backported label Jul 27, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString_FailOpenEnabled

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #8940 (ba8a21b) into main (4ad4182) will increase coverage by 0.13%.
Report is 1 commits behind head on main.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##               main    #8940      +/-   ##
============================================
+ Coverage     70.97%   71.11%   +0.13%     
- Complexity    57155    57242      +87     
============================================
  Files          4758     4758              
  Lines        269869   269869              
  Branches      39487    39487              
============================================
+ Hits         191545   191914     +369     
+ Misses        62119    61711     -408     
- Partials      16205    16244      +39     
Files Changed Coverage Δ
...rg/opensearch/core/xcontent/MediaTypeRegistry.java 82.14% <0.00%> (ø)
.../opensearch/client/indices/CreateIndexRequest.java 77.77% <100.00%> (+1.11%) ⬆️
...g/opensearch/client/indices/PutMappingRequest.java 72.41% <100.00%> (ø)
.../opensearch/core/common/io/stream/StreamInput.java 89.62% <100.00%> (+0.97%) ⬆️
...n/java/org/opensearch/core/xcontent/MediaType.java 100.00% <100.00%> (ø)
...a/org/opensearch/common/xcontent/XContentType.java 100.00% <100.00%> (ø)
.../java/org/opensearch/rest/AbstractRestChannel.java 90.69% <100.00%> (ø)
...ava/org/opensearch/transport/TransportService.java 79.10% <100.00%> (-0.72%) ⬇️

... and 466 files with indirect coverage changes

@nknize nknize merged commit 3c973ba into opensearch-project:main Jul 27, 2023
43 checks passed
@Yury-Fridlyand
Copy link

More breaking changes for god of breaking changes!

baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 28, 2023
…roject#8940)

This commit rote refactors MediaTypeParserRegistry to MediaTypeRegistry
to make the class naming align with the intention of the logic. The
MediaTypeRegistry is a mechanism for downstream extensions to register
concrete MediaTypes thus having Parser in the name is unneeded.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…roject#8940)

This commit rote refactors MediaTypeParserRegistry to MediaTypeRegistry
to make the class naming align with the intention of the logic. The
MediaTypeRegistry is a mechanism for downstream extensions to register
concrete MediaTypes thus having Parser in the name is unneeded.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added backport 2.x Backport to 2.x branch and removed pending backport Identifies an issue or PR that still needs to be backported labels Aug 1, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 1, 2023
This commit rote refactors MediaTypeParserRegistry to MediaTypeRegistry
to make the class naming align with the intention of the logic. The
MediaTypeRegistry is a mechanism for downstream extensions to register
concrete MediaTypes thus having Parser in the name is unneeded.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 3c973ba)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nknize pushed a commit that referenced this pull request Aug 1, 2023
This commit rote refactors MediaTypeParserRegistry to MediaTypeRegistry
to make the class naming align with the intention of the logic. The
MediaTypeRegistry is a mechanism for downstream extensions to register
concrete MediaTypes thus having Parser in the name is unneeded.


(cherry picked from commit 3c973ba)

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…roject#8940)

This commit rote refactors MediaTypeParserRegistry to MediaTypeRegistry
to make the class naming align with the intention of the logic. The
MediaTypeRegistry is a mechanism for downstream extensions to register
concrete MediaTypes thus having Parser in the name is unneeded.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…roject#8940)

This commit rote refactors MediaTypeParserRegistry to MediaTypeRegistry
to make the class naming align with the intention of the logic. The
MediaTypeRegistry is a mechanism for downstream extensions to register
concrete MediaTypes thus having Parser in the name is unneeded.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…roject#8940)

This commit rote refactors MediaTypeParserRegistry to MediaTypeRegistry
to make the class naming align with the intention of the logic. The
MediaTypeRegistry is a mechanism for downstream extensions to register
concrete MediaTypes thus having Parser in the name is unneeded.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request skip-changelog v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants