-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Amending tests to include all codecs #8955
Merged
reta
merged 1 commit into
opensearch-project:2.x
from
sarthakaggarwal97:backport/backport-8907-to-2.x
Aug 2, 2023
Merged
[Backport 2.x] Amending tests to include all codecs #8955
reta
merged 1 commit into
opensearch-project:2.x
from
sarthakaggarwal97:backport/backport-8907-to-2.x
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakaggarwal97
changed the title
amending tests to include all codecs (#8907)
[Backport 2.x] Amending tests to include all codecs (#8907)
Jul 28, 2023
sarthakaggarwal97
changed the title
[Backport 2.x] Amending tests to include all codecs (#8907)
[Backport 2.x] Amending tests to include all codecs
Jul 28, 2023
Gradle Check (Jenkins) Run Completed with:
|
sarthakaggarwal97
force-pushed
the
backport/backport-8907-to-2.x
branch
from
July 28, 2023 09:30
c255cc7
to
53441f3
Compare
Gradle Check (Jenkins) Run Completed with:
|
reta
requested changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not backport, see #8968
noted @reta |
Cause of the flakyness: #8968 (comment) |
sarthakaggarwal97
force-pushed
the
backport/backport-8907-to-2.x
branch
from
July 29, 2023 10:42
53441f3
to
2596b36
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #8955 +/- ##
============================================
- Coverage 70.82% 70.80% -0.02%
- Complexity 57375 57423 +48
============================================
Files 4749 4749
Lines 271395 271395
Branches 40055 40055
============================================
- Hits 192213 192160 -53
- Misses 62638 62790 +152
+ Partials 16544 16445 -99 |
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
force-pushed
the
backport/backport-8907-to-2.x
branch
from
August 2, 2023 13:24
2596b36
to
678ea17
Compare
sarthakaggarwal97
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan and
saratvemulapalli
as code owners
August 2, 2023 13:25
sarthakaggarwal97
requested review from
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis,
sachinpkale and
sohami
as code owners
August 2, 2023 13:25
reta
approved these changes
Aug 2, 2023
reta
added
backport
PRs or issues specific to backporting features or enhancments
skip-changelog
labels
Aug 2, 2023
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sarthak Aggarwal sarthagg@amazon.com
Description
Backport to
#8907#8987Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.