Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Amending tests to include all codecs #8955

Merged

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Jul 28, 2023

Signed-off-by: Sarthak Aggarwal sarthagg@amazon.com

Description

Backport to #8907 #8987

Check List

  • New functionality includes testing.
    • All tests pass
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sarthakaggarwal97 sarthakaggarwal97 changed the title amending tests to include all codecs (#8907) [Backport 2.x] Amending tests to include all codecs (#8907) Jul 28, 2023
@sarthakaggarwal97 sarthakaggarwal97 changed the title [Backport 2.x] Amending tests to include all codecs (#8907) [Backport 2.x] Amending tests to include all codecs Jul 28, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8907-to-2.x branch from c255cc7 to 53441f3 Compare July 28, 2023 09:30
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not backport, see #8968

@sarthakaggarwal97
Copy link
Contributor Author

noted @reta

@sarthakaggarwal97
Copy link
Contributor Author

Cause of the flakyness: #8968 (comment)

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8907-to-2.x branch from 53441f3 to 2596b36 Compare July 29, 2023 10:42
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #8955 (678ea17) into 2.x (558b56d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #8955      +/-   ##
============================================
- Coverage     70.82%   70.80%   -0.02%     
- Complexity    57375    57423      +48     
============================================
  Files          4749     4749              
  Lines        271395   271395              
  Branches      40055    40055              
============================================
- Hits         192213   192160      -53     
- Misses        62638    62790     +152     
+ Partials      16544    16445      -99     

see 452 files with indirect coverage changes

@reta reta mentioned this pull request Aug 2, 2023
3 tasks
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@reta reta added backport PRs or issues specific to backporting features or enhancments skip-changelog labels Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled

@reta reta merged commit 618dba4 into opensearch-project:2.x Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants