Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BWC] Change BWC version check for MediaType #9035

Merged

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Aug 1, 2023

This PR changes the bwc version check for serializing MediaTypes over the transport wire after backporting changes to 2.x.

depends on #9033

This commit changes the bwc version check for serializing MediaTypes
over the transport wire after backporting changes to 2.x.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues backwards-compatibility v3.0.0 Issues and PRs related to version 3.0.0 skip-changelog labels Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator Author

nknize commented Aug 1, 2023

Refiring now that the 2.x change merged.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #9035 (e655543) into main (22893b1) will decrease coverage by 0.16%.
Report is 1 commits behind head on main.
The diff coverage is 10.00%.

@@             Coverage Diff              @@
##               main    #9035      +/-   ##
============================================
- Coverage     71.11%   70.95%   -0.16%     
- Complexity    57241    57243       +2     
============================================
  Files          4765     4765              
  Lines        270289   270289              
  Branches      39533    39533              
============================================
- Hits         192216   191789     -427     
- Misses        61847    62338     +491     
+ Partials      16226    16162      -64     
Files Changed Coverage Δ
.../cluster/storedscripts/PutStoredScriptRequest.java 64.91% <0.00%> (+3.50%) ⬆️
...java/org/opensearch/action/index/IndexRequest.java 79.43% <0.00%> (-0.94%) ⬇️
...g/opensearch/action/ingest/PutPipelineRequest.java 75.00% <0.00%> (ø)
...nsearch/action/ingest/SimulatePipelineRequest.java 57.14% <0.00%> (ø)
...search/action/search/PutSearchPipelineRequest.java 26.66% <0.00%> (ø)
...ensearch/extensions/rest/ExtensionRestRequest.java 73.25% <0.00%> (ø)
...ensearch/index/query/MoreLikeThisQueryBuilder.java 79.69% <0.00%> (-0.52%) ⬇️
...a/org/opensearch/ingest/PipelineConfiguration.java 82.35% <0.00%> (ø)
...nsearch/search/pipeline/PipelineConfiguration.java 28.84% <0.00%> (ø)
...nsearch/action/termvectors/TermVectorsRequest.java 67.50% <100.00%> (ø)

... and 446 files with indirect coverage changes

@reta reta merged commit cc641eb into opensearch-project:main Aug 1, 2023
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
This commit changes the bwc version check for serializing MediaTypes
over the transport wire after backporting changes to 2.x.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
This commit changes the bwc version check for serializing MediaTypes
over the transport wire after backporting changes to 2.x.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
This commit changes the bwc version check for serializing MediaTypes
over the transport wire after backporting changes to 2.x.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-compatibility non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues skip-changelog v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants