Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BWC] Change BWC version check for MediaType in PercolateQueryBuilder #9053

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Aug 1, 2023

This changes the version check for MediaType in PercolateQueryBuilder for BWC.

This changes the version check for MediaType in PercolateQueryBuilder
for BWC.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues backwards-compatibility v3.0.0 Issues and PRs related to version 3.0.0 skip-changelog labels Aug 1, 2023
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 34m 58s

@nknize
Copy link
Collaborator Author

nknize commented Aug 2, 2023

Oh yeah. We're going to have LOTS of false negatives because many downstreams don't have their main branch in sync w/ core main.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testReplicationAfterForceMerge
      1 org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #9053 (7ce57b2) into main (f9158f3) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #9053      +/-   ##
============================================
+ Coverage     70.98%   71.02%   +0.04%     
- Complexity    57246    57262      +16     
============================================
  Files          4765     4765              
  Lines        270293   270293              
  Branches      39533    39533              
============================================
+ Hits         191868   191988     +120     
+ Misses        62271    62160     -111     
+ Partials      16154    16145       -9     
Files Changed Coverage Δ
...g/opensearch/percolator/PercolateQueryBuilder.java 81.93% <0.00%> (ø)

... and 486 files with indirect coverage changes

@reta reta merged commit 11c8426 into opensearch-project:main Aug 2, 2023
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…opensearch-project#9053)

This changes the version check for MediaType in PercolateQueryBuilder
for BWC.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…opensearch-project#9053)

This changes the version check for MediaType in PercolateQueryBuilder
for BWC.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…opensearch-project#9053)

This changes the version check for MediaType in PercolateQueryBuilder
for BWC.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-compatibility non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues skip-changelog v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants