-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BWC] Change BWC version check for MediaType in PercolateQueryBuilder #9053
Merged
reta
merged 1 commit into
opensearch-project:main
from
nknize:mediaTypeRegistryPercolatorBuilderVersion
Aug 2, 2023
Merged
[BWC] Change BWC version check for MediaType in PercolateQueryBuilder #9053
reta
merged 1 commit into
opensearch-project:main
from
nknize:mediaTypeRegistryPercolatorBuilderVersion
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the version check for MediaType in PercolateQueryBuilder for BWC. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added
non-issue
bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues
backwards-compatibility
v3.0.0
Issues and PRs related to version 3.0.0
skip-changelog
labels
Aug 1, 2023
nknize
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis,
sachinpkale and
sohami
as code owners
August 1, 2023 23:58
mch2
approved these changes
Aug 2, 2023
Compatibility status:
|
Oh yeah. We're going to have LOTS of false negatives because many downstreams don't have their main branch in sync w/ core main. |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9053 +/- ##
============================================
+ Coverage 70.98% 71.02% +0.04%
- Complexity 57246 57262 +16
============================================
Files 4765 4765
Lines 270293 270293
Branches 39533 39533
============================================
+ Hits 191868 191988 +120
+ Misses 62271 62160 -111
+ Partials 16154 16145 -9
|
reta
approved these changes
Aug 2, 2023
6 tasks
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
…opensearch-project#9053) This changes the version check for MediaType in PercolateQueryBuilder for BWC. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
…opensearch-project#9053) This changes the version check for MediaType in PercolateQueryBuilder for BWC. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…opensearch-project#9053) This changes the version check for MediaType in PercolateQueryBuilder for BWC. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backwards-compatibility
non-issue
bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues
skip-changelog
v3.0.0
Issues and PRs related to version 3.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the version check for
MediaType
inPercolateQueryBuilder
for BWC.