-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base class for parameterizing the search based tests #9083
Add base class for parameterizing the search based tests #9083
Conversation
110efe1
to
394303d
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:
|
test/framework/src/main/java/org/opensearch/test/ConcurrentSearchIntegTestCase.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/opensearch/test/ConcurrentSearchIntegTestCase.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/opensearch/test/ConcurrentSearchIntegTestCase.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #9083 +/- ##
============================================
+ Coverage 71.10% 71.11% +0.01%
- Complexity 57415 57453 +38
============================================
Files 4775 4775
Lines 270700 270700
Branches 39566 39566
============================================
+ Hits 192483 192516 +33
+ Misses 62066 62011 -55
- Partials 16151 16173 +22
|
test/framework/src/main/java/org/opensearch/test/ParameterizedOpenSearchIntegTestCase.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/opensearch/test/ParameterizedOpenSearchIntegTestCase.java
Show resolved
Hide resolved
test/framework/src/main/java/org/opensearch/test/ParameterizedOpenSearchIntegTestCase.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/opensearch/test/ParameterizedOpenSearchIntegTestCase.java
Outdated
Show resolved
Hide resolved
6df9416
to
133f993
Compare
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
testPreserveLatestCommit - this test is failing but looks unrelated to my changes. |
test/framework/src/main/java/org/opensearch/test/ParameterizedOpenSearchIntegTestCase.java
Outdated
Show resolved
Hide resolved
133f993
to
a34ecb8
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
a34ecb8
to
e41c46c
Compare
Gradle Check (Jenkins) Run Completed with:
|
testRestoreInSameRemoteStoreEnabledIndex - flaky test |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9083-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a7eade4664cebc23334822bbc1a426be379a50f
# Push it to GitHub
git push --set-upstream origin backport/backport-9083-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…project#9083) Signed-off-by: Neetika Singhal <neetiks@amazon.com> (cherry picked from commit 0a7eade)
…project#9083) Signed-off-by: Neetika Singhal <neetiks@amazon.com> (cherry picked from commit 0a7eade)
…project#9083) Signed-off-by: Neetika Singhal <neetiks@amazon.com> Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
…project#9083) Signed-off-by: Neetika Singhal <neetiks@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…project#9083) Signed-off-by: Neetika Singhal <neetiks@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
…project#9083) Signed-off-by: Neetika Singhal <neetiks@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Create a sub-class ConcurrentSearchIntegTestCase of OpenSearchIntegTestCase that has a constructor to work with the @ParametersFactory to create parameters’ values of the concurrent search cluster setting as true/false.
This PR contains the changes to only base classes for which the tests already exist in the main branch.
Changing all the other Search ITs to extend the new base class ConcurrentSearchIntegTestCase and initialize the base class constructor will be done in the follow-up PR as it involves changing a lot of classes.
Related Issues
Resolves #8673
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.