Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Add missing unit test in main #9101

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Aug 3, 2023

Description

Forward port unit test testUploadMetadataMissingSegment added in #8653

Related Issues

Resolves None

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89 dreamer-89 self-assigned this Aug 3, 2023
@dreamer-89 dreamer-89 added :test Adding or fixing a test Indexing:Replication Issues and PRs related to core replication framework eg segrep labels Aug 3, 2023
@dreamer-89 dreamer-89 added the Storage Issues and PRs relating to data and metadata storage label Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

Screenshot 2023-08-03 at 1 23 36 PM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #9101 (2c6f160) into main (e55dade) will decrease coverage by 0.03%.
Report is 4 commits behind head on main.
The diff coverage is 69.23%.

@@             Coverage Diff              @@
##               main    #9101      +/-   ##
============================================
- Coverage     71.03%   71.00%   -0.03%     
+ Complexity    57314    57275      -39     
============================================
  Files          4765     4765              
  Lines        270357   270380      +23     
  Branches      39543    39546       +3     
============================================
- Hits         192043   191993      -50     
- Misses        62151    62249      +98     
+ Partials      16163    16138      -25     
Files Changed Coverage Δ
...search/index/shard/RemoteStoreRefreshListener.java 82.51% <0.00%> (-6.44%) ⬇️
...ckpoint/SegmentReplicationCheckpointPublisher.java 100.00% <ø> (ø)
...s/replication/SegmentReplicationTargetService.java 60.00% <57.69%> (+0.74%) ⬆️
.../opensearch/index/engine/NRTReplicationEngine.java 78.98% <66.66%> (-0.49%) ⬇️
.../indices/replication/SegmentReplicationTarget.java 89.71% <85.71%> (+0.39%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 69.33% <86.95%> (-0.41%) ⬇️

... and 488 files with indirect coverage changes

@dreamer-89
Copy link
Member Author

Codecov is reporting missing coverage for unrelated changes. Ignoring.
Check compatibility is currently flaky. Anyway, with this PR we are only adding a unit test, so ignoring this check. I retried it once already CC @gaiksaya

@dreamer-89 dreamer-89 merged commit 9357b61 into opensearch-project:main Aug 3, 2023
@gaiksaya
Copy link
Member

gaiksaya commented Aug 3, 2023

Codecov is reporting missing coverage for unrelated changes. Ignoring. Check compatibility is currently flaky. Anyway, with this PR we are only adding a unit test, so ignoring this check. I retried it once already CC @gaiksaya

Yes they are false negatives since plugins' branches are not in sync with core yet! See attached open issues in this PR: #9073

kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing:Replication Issues and PRs related to core replication framework eg segrep skip-changelog Storage Issues and PRs relating to data and metadata storage :test Adding or fixing a test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants