Update search.concurrent.max_slice setting to dynamic cluster setting for main with lucene-9.8 #9107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohami
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
Gradle Check (Jenkins) Run Completed with:
|
sohami
force-pushed
the
issue-8870-new
branch
3 times, most recently
from
cd2ff62
to
f1bd76a
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
Compatibility status: |
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9107 +/- ##
============================================
+ Coverage 71.06% 71.13% +0.07%
- Complexity 57314 57323 +9
============================================
Files 4766 4766
Lines 270453 270504 +51
Branches 39555 39555
============================================
+ Hits 192197 192434 +237
+ Misses 62045 61829 -216
- Partials 16211 16241 +30
|
Gradle Check (Jenkins) Run Completed with:
|
Related to this #9092 |
|
@reta Can you please help with the review. |
andrross
approved these changes
Aug 4, 2023
server/src/main/java/org/opensearch/search/internal/MaxTargetSliceSupplier.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/search/internal/IndexReaderUtils.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/search/internal/IndexReaderUtils.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/DefaultSearchContext.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Aug 7, 2023
server/src/main/java/org/opensearch/search/internal/ContextIndexSearcher.java
Outdated
Show resolved
Hide resolved
… for main with lucene-9.8 Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
reta
approved these changes
Aug 7, 2023
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
andrross
approved these changes
Aug 7, 2023
5 tasks
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
… for main with lucene-9.8 (opensearch-project#9107) * Update search.concurrent.max_slice setting to dynamic cluster setting for main with lucene-9.8 Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com> * Address review comments Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com> --------- Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
… for main with lucene-9.8 (opensearch-project#9107) * Update search.concurrent.max_slice setting to dynamic cluster setting for main with lucene-9.8 Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com> * Address review comments Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com> --------- Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
6 tasks
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
… for main with lucene-9.8 (opensearch-project#9107) * Update search.concurrent.max_slice setting to dynamic cluster setting for main with lucene-9.8 Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com> * Address review comments Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com> --------- Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #7358 to make the setting
search.concurrent.max_slicedynamic in main (with lucene 9.8 version). This PR will not be backported to 2.x unless lucene 9.8 is released and available in 2.x branch. Until then we will use the static setting mechanism for 2.x branch supported by previous PR.Related Issues
#8870
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.