-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CheckCompatibility] Prevent interleaving of log output #9280
Conversation
Signed-off-by: Peter Nied <petern@amazon.com>
buildSrc/src/main/groovy/org/opensearch/gradle/CheckCompatibilityTask.groovy
Show resolved
Hide resolved
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
Is it possible to make output more readable (and with MD)? For example:
This message could also include tagging the corresponding teams. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. LGTM.
buildSrc/src/main/groovy/org/opensearch/gradle/CheckCompatibilityTask.groovy
Show resolved
Hide resolved
Signed-off-by: Peter Nied <petern@amazon.com>
fe1e87e
to
8518854
Compare
Compatibility status:
|
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9280 +/- ##
============================================
+ Coverage 71.11% 71.23% +0.12%
- Complexity 57351 57517 +166
============================================
Files 4771 4774 +3
Lines 270587 270664 +77
Branches 39564 39570 +6
============================================
+ Hits 192420 192813 +393
+ Misses 61950 61708 -242
+ Partials 16217 16143 -74
|
@gaiksaya - would you be willing to approve? |
LGTM. Thanks, @peternied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 23fd9a5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 23fd9a5) Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…roject#9280) Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
…roject#9280) Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…roject#9280) Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
…roject#9280) Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Prevent interleaving of log output and add more detail logging
Example output at standard log level
Updated status report comment with markdown:
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.