Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change noisy logs on SegRep and remote store paths to trace level #9323

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Aug 14, 2023

Description

Change noisy logs on SegRep and remote store paths to trace level

Related Issues

Resolves #8452

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Marc Handalian <handalm@amazon.com>
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 29m 5s

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member Author

mch2 commented Aug 14, 2023

#7679

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member Author

mch2 commented Aug 14, 2023

Gradle Check (Jenkins) Run Completed with:

#9326

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member

Gradle Check (Jenkins) Run Completed with:

More flakies :(

Screenshot 2023-08-14 at 4 47 58 PM

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #9323 (b47f182) into main (8cecd5a) will decrease coverage by 0.02%.
Report is 5 commits behind head on main.
The diff coverage is 72.72%.

@@             Coverage Diff              @@
##               main    #9323      +/-   ##
============================================
- Coverage     71.10%   71.09%   -0.02%     
+ Complexity    57415    57398      -17     
============================================
  Files          4775     4775              
  Lines        270700   270700              
  Branches      39566    39566              
============================================
- Hits         192483   192446      -37     
- Misses        62066    62067       +1     
- Partials      16151    16187      +36     
Files Changed Coverage Δ
...src/main/java/org/opensearch/ExceptionsHelper.java 82.71% <ø> (ø)
.../main/java/org/opensearch/OpenSearchException.java 89.72% <ø> (-1.39%) ⬇️
...rch/core/action/ShardOperationFailedException.java 100.00% <ø> (ø)
.../support/DefaultShardOperationFailedException.java 95.65% <ø> (ø)
...a/org/opensearch/core/common/ParsingException.java 96.66% <ø> (ø)
.../core/common/breaker/CircuitBreakingException.java 100.00% <ø> (ø)
.../opensearch/core/common/io/stream/StreamInput.java 89.43% <ø> (+1.76%) ⬆️
...opensearch/core/common/io/stream/StreamOutput.java 95.98% <ø> (+1.44%) ⬆️
...src/main/java/org/opensearch/core/index/Index.java 100.00% <ø> (ø)
.../java/org/opensearch/core/index/shard/ShardId.java 97.56% <ø> (ø)
... and 41 more

... and 446 files with indirect coverage changes

@dreamer-89
Copy link
Member

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

testDropPrimaryDuringReplication -> #8059
testTaskResourceTrackingDuringTaskCancellation -> #5329
SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all} -> #9332

@dreamer-89 dreamer-89 merged commit 64be0ab into opensearch-project:main Aug 15, 2023
@dreamer-89 dreamer-89 added the backport 2.x Backport to 2.x branch label Aug 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 15, 2023
)

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 64be0ab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2 pushed a commit that referenced this pull request Aug 15, 2023
) (#9333)

(cherry picked from commit 64be0ab)

Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
…ensearch-project#9323)

Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…ensearch-project#9323)

Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…ensearch-project#9323)

Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ensearch-project#9323)

Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove excessive logging with SegRep using Remote store
3 participants