Fix testClusterRelocationNoPreferenceShardMovementPrimaryFirstEnabled failure due to timeout

[Poojita-Raj]

Description

Fixes the flaky timeout issue on testClusterRelocationNoPreferenceShardMovementPrimaryFirstEnabled so it passes every time as expected.

The issue was incorrect detection of the primary first shard movement strategy for throttling in the event that ShardMovementStrategy is set to NO_PREFERENCE and movePrimaryFirst deprecated setting is set to true.
Changed the logic of setting the shard movement strategy value.

Related Issues

Resolves #9178

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[Poojita-Raj]

Ran each test 200 times to confirm there's no flakiness.

[opensearch-trigger-bot]

Compatibility status:

Checks if related components are compatible with change 914544b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.client.PitIT.testDeleteAllAndListAllPits

• URL: https://build.ci.opensearch.org/job/gradle-check/22991/
• CommitID: 1cdc8c8
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #9420 (1cdc8c8) into main (6a5b464) will increase coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main    #9420      +/-   ##
============================================
+ Coverage     71.12%   71.17%   +0.05%     
- Complexity    57417    57470      +53     
============================================
  Files          4776     4776              
  Lines        270742   270738       -4     
  Branches      39578    39578              
============================================
+ Hits         192558   192691     +133     
+ Misses        62044    61804     -240     
- Partials      16140    16243     +103     

Files Changed	Coverage Δ
.../allocation/allocator/BalancedShardsAllocator.java	91.74% <75.00%> (+0.12%)	⬆️
...ting/allocation/allocator/LocalShardsBalancer.java	85.52% <100.00%> (-0.01%)	⬇️

... and 448 files with indirect coverage changes

[mch2]

Thanks @Poojita-Raj can you link this to a docs issue?