Add benchmark to measure CustomBinaryDocValuesField performance #9426
Conversation
kkmr
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis,
sachinpkale and
sohami
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/index/mapper/BinaryFieldMapper.java
Outdated
Show resolved
Hide resolved
|
It looks like the old code performs much better. Most likely, the performance is not dominated by the sort. New code PerformanceOld code performance |
Gradle Check (Jenkins) Run Completed with:
|
andrross
changed the title
andrross
changed the title
Benchmarks show that ArrayList performs better than TreeSet. Added a comment on where to find the results and benchmark. Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change c3ff05d Incompatible componentsIncompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9426 +/- ##
============================================
- Coverage 71.53% 71.12% -0.41%
+ Complexity 57897 57580 -317
============================================
Files 4782 4782
Lines 271332 271332
Branches 39614 39614
============================================
- Hits 194107 192997 -1110
- Misses 61255 62073 +818
- Partials 15970 16262 +292
|
Compatibility status:Checks if related components are compatible with change 47056c3 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
Known test failure: #9580 |
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
…9426) (#9649) Benchmarks show that ArrayList performs better than TreeSet. Added a comment on where to find the results and benchmark. (cherry picked from commit cc007e4) Signed-off-by: Kiran Reddy <kkreddy@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…pensearch-project#9426) Benchmarks show that ArrayList performs better than TreeSet. Added a comment on where to find the results and benchmark. Signed-off-by: Kiran Reddy <kkreddy@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…pensearch-project#9426) Benchmarks show that ArrayList performs better than TreeSet. Added a comment on where to find the results and benchmark. Signed-off-by: Kiran Reddy <kkreddy@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
…pensearch-project#9426) Benchmarks show that ArrayList performs better than TreeSet. Added a comment on where to find the results and benchmark. Signed-off-by: Kiran Reddy <kkreddy@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Add benchmark to measure CustomBinaryDocValuesField.
Description
We were considering using a TreeMap in CustomBinaryDocValuesField instead of ArrayList. Benchmarks showed that ArrayList performs better. We are keeping the benchmark code for future reference.
Related Issues
Resolves #6897
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.