-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the script sort related ITs #9466
Conversation
26c6d03
to
4607490
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 61c5f17 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
4607490
to
36edd6f
Compare
server/src/main/java/org/opensearch/search/sort/ScriptSortBuilder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/sort/ScriptSortBuilder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/sort/ScriptSortBuilder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/sort/ScriptSortBuilder.java
Outdated
Show resolved
Hide resolved
36edd6f
to
3674360
Compare
@reta waiting for your review. |
server/src/main/java/org/opensearch/search/sort/ScriptSortBuilder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/sort/ScriptSortBuilder.java
Outdated
Show resolved
Hide resolved
@neetikasinghal sincere apologies, added few comments but LGTM as approach (have nothing better to suggest) |
3674360
to
4177ff6
Compare
server/src/main/java/org/opensearch/search/sort/ScriptSortBuilder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/sort/ScriptSortBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
4177ff6
to
b59b57a
Compare
.../main/java/org/opensearch/index/fielddata/fieldcomparator/BytesRefFieldComparatorSource.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change d1678ba Incompatible componentsIncompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9466-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a6c0bb30f93db1c0d5204211273650dfb6eda7d4
# Push it to GitHub
git push --set-upstream origin backport/backport-9466-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
Signed-off-by: Neetika Singhal <neetiks@amazon.com> Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Neetika Singhal <neetiks@amazon.com> Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Neetika Singhal <neetiks@amazon.com> Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
Signed-off-by: Neetika Singhal <neetiks@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Neetika Singhal <neetiks@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
Signed-off-by: Neetika Singhal <neetiks@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Solves the sort related ITs
Related Issues
Resolves #8510
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.