Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Allow MockTracingTelemetry to await for asynchronous tasks termination before validating spans #9646

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0274095 from #9561.

…n before validating spans (#9561)

* Allow MockTracingTelemetry to await for asynchronous tasks termination before validating spans

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Address code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 0274095)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change d167e16

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #9646 (d167e16) into 2.x (945c4b5) will increase coverage by 0.14%.
Report is 1 commits behind head on 2.x.
The diff coverage is 78.50%.

@@             Coverage Diff              @@
##                2.x    #9646      +/-   ##
============================================
+ Coverage     70.74%   70.89%   +0.14%     
- Complexity    57629    57751     +122     
============================================
  Files          4769     4770       +1     
  Lines        272600   272705     +105     
  Branches      40132    40147      +15     
============================================
+ Hits         192853   193323     +470     
+ Misses        63281    62766     -515     
- Partials      16466    16616     +150     
Files Changed Coverage Δ
...a/org/opensearch/action/search/SearchResponse.java 88.42% <70.00%> (-1.21%) ⬇️
...org/opensearch/search/GenericSearchExtBuilder.java 73.84% <73.84%> (ø)
...ensearch/action/search/SearchResponseSections.java 97.43% <100.00%> (+1.13%) ⬆️
...search/search/internal/InternalSearchResponse.java 100.00% <100.00%> (ø)

... and 479 files with indirect coverage changes

@andrross andrross merged commit 21da767 into 2.x Aug 30, 2023
@github-actions github-actions bot deleted the backport/backport-9561-to-2.x branch August 30, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants