Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] [Tracing Framework] Redefine telemetry context restoration and propag… #9701

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

Gaganjuneja
Copy link
Contributor

Description

2.x Backport PR of - #9617

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ation (opensearch-project#9617)

* Add SpanBuilder support

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Redefine telemetry context restoration

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Update changelog

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Stores the SpanScope in ThreadLocal

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Revert the context name changes

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Change the span::endSpan and SpanScope::close behaviour

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Supressed warnings

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add more test cases

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix java doc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix failing test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
@reta reta changed the title [Tracing Framework] Redefine telemetry context restoration and propag… [Backport] [2.x] [Tracing Framework] Redefine telemetry context restoration and propag… Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Compatibility status:

Checks if related components are compatible with change c9448b8

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@reta reta added the v2.10.0 label Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #9701 (c9448b8) into 2.x (9e41df4) will decrease coverage by 0.08%.
Report is 4 commits behind head on 2.x.
The diff coverage is 76.19%.

@@             Coverage Diff              @@
##                2.x    #9701      +/-   ##
============================================
- Coverage     70.86%   70.78%   -0.08%     
- Complexity    57786    57875      +89     
============================================
  Files          4776     4793      +17     
  Lines        273121   273414     +293     
  Branches      40198    40216      +18     
============================================
- Hits         193537   193530       -7     
- Misses        63032    63333     +301     
+ Partials      16552    16551       -1     
Files Changed Coverage Δ
...java/org/opensearch/common/crypto/DataKeyPair.java 0.00% <0.00%> (ø)
...ain/java/org/opensearch/common/unit/TimeValue.java 87.50% <ø> (+1.25%) ⬆️
...ibs/core/src/main/java/org/opensearch/Version.java 83.33% <ø> (-0.44%) ⬇️
.../src/main/java/org/opensearch/core/ParseField.java 95.65% <ø> (ø)
...ava/org/opensearch/core/action/ActionListener.java 83.17% <0.00%> (+2.80%) ⬆️
...g/opensearch/core/common/bytes/BytesReference.java 88.57% <ø> (+14.28%) ⬆️
.../core/common/io/stream/NamedWriteableRegistry.java 100.00% <ø> (ø)
.../opensearch/core/common/io/stream/StreamInput.java 88.64% <ø> (-0.20%) ⬇️
...opensearch/core/common/io/stream/StreamOutput.java 94.88% <ø> (-0.81%) ⬇️
.../opensearch/core/common/settings/SecureString.java 78.78% <ø> (ø)
... and 66 more

... and 447 files with indirect coverage changes

@reta reta merged commit 776d77c into opensearch-project:2.x Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants