-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable remote integrity check for encrypted repos for ChecksumBlobstoreFormat #9908
Disable remote integrity check for encrypted repos for ChecksumBlobstoreFormat #9908
Conversation
…toreFormat Signed-off-by: bansvaru <bansvaru@amazon.com>
server/src/main/java/org/opensearch/repositories/blobstore/ChecksumBlobStoreFormat.java
Show resolved
Hide resolved
Compatibility status:Checks if related components are compatible with change ac73764 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
Gradle Check (Jenkins) Run Completed with:
|
ac73764
to
772c8b0
Compare
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 772c8b0 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
build is UNSTABLE. maybe because it took 1.5 hours due to jenkins issue
ran this locally and it passed. test seems flaky |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9908 +/- ##
============================================
+ Coverage 71.02% 71.09% +0.06%
- Complexity 58040 58079 +39
============================================
Files 4831 4831
Lines 273927 274000 +73
Branches 39913 39920 +7
============================================
+ Hits 194567 194796 +229
+ Misses 63061 62830 -231
- Partials 16299 16374 +75
... and 435 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
…oreFormat (opensearch-project#9908) Signed-off-by: bansvaru <bansvaru@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…oreFormat (opensearch-project#9908) Signed-off-by: bansvaru <bansvaru@amazon.com>
…oreFormat (opensearch-project#9908) Signed-off-by: bansvaru <bansvaru@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
…oreFormat (opensearch-project#9908) Signed-off-by: bansvaru <bansvaru@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Impact
Remote Metadata Store would break with encrypted repositories as there will be checksum mismatch while uploading to remote .
Related Issues
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.