Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OUI Next Theme) Alerting #663

Closed
4 tasks done
Tracked by #895
KrooshalUX opened this issue Jul 25, 2023 · 0 comments
Closed
4 tasks done
Tracked by #895

(OUI Next Theme) Alerting #663

KrooshalUX opened this issue Jul 25, 2023 · 0 comments
Labels
roadmap v2.10.0 Issues targeting release v2.10.0

Comments

@KrooshalUX
Copy link

KrooshalUX commented Jul 25, 2023

This issue to be transferred to corresponding repository

I am working on launching new light and dark mode themes provided by OUI component library for a target launch within 2.10. These changes support the vision expressed in Future Vision for Dashboards

I have identified the following front end related issues that prevent the theme from appearing complete and potential solutions within this feature:

Global

  • Duplicate breadcrumb appears on page. Breadcrumb should appear within EuiHeader.

Create Monitor flow

  • Query section: empty state (before a user selects an index) appears with a border with a manually set color value. In dark mode, this appears as a bright-white border.
    - Resolution Option 1 (best): To align to best practices, EuiEmptyPrompt should be used for empty states.
    - Resolution Option 2 (ok for short term): Remove hard coded color value in favor of using sass variable $ouiColorLightShade that will adjust appropriately across light and dark mode
Screen Shot 2023-07-25 at 2 31 50 PM
  • Trigger section: Empty state "loading destinations" appears on a background with a manually set background color value. In dark mode, this appears as a bright-white background and the text is not legible.
    - Resolution Option 1 (best): To align to best practices, EuiEmptyPrompt should be used for empty loading state
    - Resolution Option 2 (ok for short term): Remove background
Screen Shot 2023-07-25 at 2 32 03 PM
  • "Monitor defining method", "You can add up to 9 more triggers.": Description text is set to extra small. This is creating contrast issues and a11y tests fail. The minimum description text size should be m. Only in special cases should s and xs should be used.
@wbeckler wbeckler transferred this issue from opensearch-project/oui Jul 26, 2023
@wbeckler wbeckler added v2.10.0 Issues targeting release v2.10.0 and removed v2.1.0 labels Aug 7, 2023
@amsiglan amsiglan closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap v2.10.0 Issues targeting release v2.10.0
Projects
None yet
Development

No branches or pull requests

4 participants