Updates for dark mode theme #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #695 +/- ##
==========================================
- Coverage 49.87% 49.85% -0.02%
==========================================
Files 233 233
Lines 6567 6561 -6
Branches 938 939 +1
==========================================
- Hits 3275 3271 -4
+ Misses 3289 3287 -2
Partials 3 3 |
lezzago
approved these changes
Aug 31, 2023
AWSHurneyt
approved these changes
Sep 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
* breadcrumbs show up in app chrome only Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated components for dark mode and ally Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added null check Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 21be3d7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 1, 2023
* breadcrumbs show up in app chrome only * updated components for dark mode and ally * added null check --------- (cherry picked from commit 21be3d7) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates few components/logic to comply with dark mode theme.
Issues Resolved
#663
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.