Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped tough-cookie, and semver versions. #649

Merged
merged 2 commits into from
Jul 15, 2023

Conversation

AWSHurneyt
Copy link
Collaborator

Description

Bumped tough-cookie, and semver versions to address dependabot alerts.

Issues Resolved

https://github.com/opensearch-project/alerting-dashboards-plugin/security/dependabot/22
https://github.com/opensearch-project/alerting-dashboards-plugin/security/dependabot/23

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #649 (afb803e) into 2.x (daa0fe0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #649   +/-   ##
=======================================
  Coverage   49.99%   49.99%           
=======================================
  Files         231      231           
  Lines        6509     6509           
  Branches      927      927           
=======================================
  Hits         3254     3254           
  Misses       3252     3252           
  Partials        3        3           

see 1 file with indirect coverage changes

@AWSHurneyt AWSHurneyt changed the title Bumped tough-cookie version. Bumped tough-cookie, and semver versions. Jul 15, 2023
@AWSHurneyt
Copy link
Collaborator Author

The failing cypress test is a known flaky test that we're tracking; suggesting that this dependency bump didn't affect the execution. We'll repair that test in a separate PR.

@AWSHurneyt AWSHurneyt merged commit 9d9aa33 into opensearch-project:2.x Jul 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 15, 2023
* Bumped tough-cookie.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Bumped semver.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit 9d9aa33)
AWSHurneyt added a commit that referenced this pull request Jul 15, 2023
* Bumped tough-cookie.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Bumped semver.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit 9d9aa33)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants