Optimize fetching of augment-vis saved objects #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago
requested review from
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
ohltyler
reviewed
Jul 20, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #659 +/- ##
=======================================
Coverage 49.99% 49.99%
=======================================
Files 231 231
Lines 6509 6509
Branches 927 927
=======================================
Hits 3254 3254
Misses 3252 3252
Partials 3 3 |
praveensameneni
approved these changes
Jul 20, 2023
amsiglan
approved these changes
Jul 20, 2023
bowenlan-amzn
approved these changes
Jul 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Optimize fetching of augment-vis saved objects Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * address comment Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 0dd05f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Optimize fetching of augment-vis saved objects Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * address comment Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 0dd05f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
lezzago
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Optimize fetching of augment-vis saved objects * address comment --------- (cherry picked from commit 0dd05f8) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
lezzago
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Optimize fetching of augment-vis saved objects * address comment --------- (cherry picked from commit 0dd05f8) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates saved object loader findAll() calls to include a hasReference argument so only objects that include the desired vis ID as a reference will be fetched. Part of opensearch-project/OpenSearch-Dashboards#4595.
Tested against cluster with the change in OSD, works as expected.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.