add workflow null or empty check only when empty workflow id passed. #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
requested review from
lezzago,
AWSHurneyt,
sbcd90,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
…change Rest get alert handler to add empty string singleton list for workflow ids when none is passed Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
71 tasks
amsiglan
approved these changes
Sep 13, 2023
lezzago
approved these changes
Sep 13, 2023
AWSHurneyt
approved these changes
Sep 13, 2023
alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportGetAlertsAction.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportGetAlertsAction.kt
Show resolved
Hide resolved
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
…1139) * add workflow null or empty check only when empty workflow id passed. change Rest get alert handler to add empty string singleton list for workflow ids when none is passed Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * extract check into method Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit d6fd871) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
…1139) * add workflow null or empty check only when empty workflow id passed. change Rest get alert handler to add empty string singleton list for workflow ids when none is passed Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * extract check into method Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit d6fd871) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
lezzago
pushed a commit
that referenced
this pull request
Sep 13, 2023
…1139) (#1150) * add workflow null or empty check only when empty workflow id passed. change Rest get alert handler to add empty string singleton list for workflow ids when none is passed * extract check into method --------- (cherry picked from commit d6fd871) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
lezzago
pushed a commit
that referenced
this pull request
Sep 13, 2023
…1139) (#1149) * add workflow null or empty check only when empty workflow id passed. change Rest get alert handler to add empty string singleton list for workflow ids when none is passed * extract check into method --------- (cherry picked from commit d6fd871) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add workflow null or empty check only when empty workflow id passed in transport get alerts request.
In Rest get alert action, add empty string singleton list for workflow ids when none is passed. This is to support returning non-Audit alerts on Alert Dashboard.