Add logging for execution and indexes of monitors and workflows #1223

lezzago · 2023-10-04T16:46:52Z

Issue #, if available:
#41

Description of changes:
Add logging around monitor and workflow executions, creations, and updates.

CheckList:

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

bowenlan-amzn · 2023-10-04T16:52:16Z

alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt

@@ -486,6 +486,13 @@ class TransportIndexMonitorAction @Inject constructor(
                .setIfPrimaryTerm(request.primaryTerm)
                .timeout(indexTimeout)

+            log.info(


I would like to suggest put the monitor body into debug level log which is a long string

opensearch-trigger-bot · 2023-10-04T18:20:57Z

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.0 2.0
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.0
# Create a new branch
git switch --create backport-1223-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport-1223-to-2.0.

opensearch-trigger-bot · 2023-10-04T18:20:59Z

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.1
# Create a new branch
git switch --create backport-1223-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport-1223-to-2.1.

opensearch-trigger-bot · 2023-10-04T18:21:01Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1223-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-1223-to-2.x.

opensearch-trigger-bot · 2023-10-04T18:21:04Z

The backport to 2.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.2 2.2
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.2
# Create a new branch
git switch --create backport-1223-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.2
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.2

Then, create a pull request where the base branch is 2.2 and the compare/head branch is backport-1223-to-2.2.

opensearch-trigger-bot · 2023-10-04T18:21:06Z

The backport to 2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.3 2.3
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.3
# Create a new branch
git switch --create backport-1223-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.3

Then, create a pull request where the base branch is 2.3 and the compare/head branch is backport-1223-to-2.3.

opensearch-trigger-bot · 2023-10-04T18:21:07Z

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.4 2.4
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.4
# Create a new branch
git switch --create backport-1223-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport-1223-to-2.4.

opensearch-trigger-bot · 2023-10-04T18:21:09Z

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.5 2.5
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.5
# Create a new branch
git switch --create backport-1223-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.5
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport-1223-to-2.5.

opensearch-trigger-bot · 2023-10-04T18:21:10Z

The backport to 2.6 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.6 2.6
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.6
# Create a new branch
git switch --create backport-1223-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.6
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.6

Then, create a pull request where the base branch is 2.6 and the compare/head branch is backport-1223-to-2.6.

opensearch-trigger-bot · 2023-10-04T18:21:12Z

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.7 2.7
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.7
# Create a new branch
git switch --create backport-1223-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport-1223-to-2.7.

opensearch-trigger-bot · 2023-10-04T18:21:14Z

The backport to 2.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.8
# Create a new branch
git switch --create backport-1223-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.8

Then, create a pull request where the base branch is 2.8 and the compare/head branch is backport-1223-to-2.8.

opensearch-trigger-bot · 2023-10-04T18:21:16Z

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.9 2.9
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.9
# Create a new branch
git switch --create backport-1223-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport-1223-to-2.9.

opensearch-trigger-bot · 2023-10-04T18:21:17Z

The backport to 2.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.10 2.10
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.10
# Create a new branch
git switch --create backport-1223-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.10
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.10

Then, create a pull request where the base branch is 2.10 and the compare/head branch is backport-1223-to-2.10.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 0a15bfd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot · 2023-10-04T18:39:43Z

The backport to 2.8 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.8
# Create a new branch
git switch --create backport-1223-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a15bfd75e9b886902971af12b4a9057a579647b
# Push it to GitHub
git push --set-upstream origin backport-1223-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.8

Then, create a pull request where the base branch is 2.8 and the compare/head branch is backport-1223-to-2.8.

… (#1224) (cherry picked from commit 0a15bfd) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

… (#1225) (cherry picked from commit 0a15bfd) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

… (#1226) (cherry picked from commit 0a15bfd) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Add logging for execution and indexes of monitors and workflows

7022912

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

lezzago requested review from AWSHurneyt, sbcd90, eirsep, getsaurabh02, praveensameneni, qreshi, bowenlan-amzn and rishabhmaurya as code owners October 4, 2023 16:46

lezzago added backport 2.x backport 2.0 backport 2.1 backport 2.2 backport 2.3 backport 2.4 backport 2.5 backport 2.6 backport 2.7 backport 2.8 backport 2.9 backports PRs to 2.9 backport 2.10 labels Oct 4, 2023

bowenlan-amzn approved these changes Oct 4, 2023

View reviewed changes

AWSHurneyt approved these changes Oct 4, 2023

View reviewed changes

lezzago merged commit 0a15bfd into opensearch-project:main Oct 4, 2023
12 of 26 checks passed

lezzago deleted the extralogging branch October 4, 2023 18:20

opensearch-trigger-bot bot added the failed backport label Oct 4, 2023

lezzago added backport 2.x and removed backport 2.x labels Oct 4, 2023

opensearch-trigger-bot bot mentioned this pull request Oct 4, 2023

[Backport 2.x] Add logging for execution and indexes of monitors and workflows #1224

Merged

lezzago added backport 2.10 and removed backport 2.10 labels Oct 4, 2023

opensearch-trigger-bot bot mentioned this pull request Oct 4, 2023

[Backport 2.10] Add logging for execution and indexes of monitors and workflows #1225

Merged

lezzago added backport 2.9 backports PRs to 2.9 and removed backport 2.9 backports PRs to 2.9 labels Oct 4, 2023

opensearch-trigger-bot bot mentioned this pull request Oct 4, 2023

[Backport 2.9] Add logging for execution and indexes of monitors and workflows #1226

Merged

lezzago added backport 2.8 and removed backport 2.8 labels Oct 4, 2023

engechas mentioned this pull request Apr 12, 2024

More logging #41

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add logging for execution and indexes of monitors and workflows #1223

Add logging for execution and indexes of monitors and workflows #1223

lezzago commented Oct 4, 2023 •

edited

Loading

bowenlan-amzn Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

Add logging for execution and indexes of monitors and workflows #1223

Add logging for execution and indexes of monitors and workflows #1223

Conversation

lezzago commented Oct 4, 2023 • edited Loading

bowenlan-amzn Oct 4, 2023

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

opensearch-trigger-bot bot commented Oct 4, 2023

lezzago commented Oct 4, 2023 •

edited

Loading