Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish notification JARs checksums. #196

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Publish notification JARs checksums. #196

merged 2 commits into from
Oct 7, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 6, 2021

Signed-off-by: dblock dblock@dblock.org

Description

  1. Publish SHA1 and MD5 signatures with the JAR artifacts.
  2. Remove signing and publishing workflow that no longer runs because the maven repo target had been removed earlier.
  3. Move in the custom build script into the repo.
$ ./scripts/build.sh -v 1.1.0 -s false

$ $ find artifacts/
artifacts/
artifacts/plugins
artifacts/plugins/opensearch-alerting-1.1.0.0.zip
artifacts/maven
artifacts/maven/org
artifacts/maven/org/opensearch
artifacts/maven/org/opensearch/notification
artifacts/maven/org/opensearch/notification/alerting-notification-1.1.0.0.jar.sha1
artifacts/maven/org/opensearch/notification/alerting-notification-1.1.0.0-sources.jar.sha1
artifacts/maven/org/opensearch/notification/alerting-notification-1.1.0.0.jar.md5
artifacts/maven/org/opensearch/notification/alerting-notification-1.1.0.0-javadoc.jar
artifacts/maven/org/opensearch/notification/alerting-notification-1.1.0.0-sources.jar.md5
artifacts/maven/org/opensearch/notification/alerting-notification-1.1.0.0-javadoc.jar.sha1
artifacts/maven/org/opensearch/notification/alerting-notification-1.1.0.0-javadoc.jar.md5
artifacts/maven/org/opensearch/notification/alerting-notification-1.1.0.0.jar
artifacts/maven/org/opensearch/notification/alerting-notification-1.1.0.0-sources.jar

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock mentioned this pull request Oct 6, 2021
Merged
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #196 (0dbbe28) into main (948aa55) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #196      +/-   ##
============================================
- Coverage     78.84%   78.79%   -0.05%     
+ Complexity      215      214       -1     
============================================
  Files           172      172              
  Lines          6948     6951       +3     
  Branches        903      905       +2     
============================================
- Hits           5478     5477       -1     
- Misses          986      987       +1     
- Partials        484      487       +3
Impacted Files Coverage Δ
...ing/destination/client/DestinationEmailClient.java 72.50% <0.00%> (-5.00%) ⬇️
...ch/alerting/resthandler/RestSearchMonitorAction.kt 87.03% <0.00%> (-3.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 948aa55...0dbbe28. Read the comment docs.

dblock added a commit to dblock/opensearch-build that referenced this pull request Oct 6, 2021
@dblock
Removed alerting that was moved to its repo.
e4e869d 
opensearch-project/alerting#196
opensearch-project/alerting#197

Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock mentioned this pull request Oct 6, 2021
Merged
1 task
@dblock
Publish notification JARs checksums.
3a44093 
Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock force-pushed the notification-jar-checksums branch from e3ffce8 to 3a44093 Compare October 6, 2021 19:21
@dblock dblock mentioned this pull request Oct 6, 2021
Merged
@dblock
Remove sonatype staging.
0dbbe28 
Signed-off-by: dblock <dblock@dblock.org>
dblock added a commit to dblock/opensearch-build that referenced this pull request Oct 6, 2021
@dblock
Removed alerting that was moved to its repo.
9aca227 
opensearch-project/alerting#196
opensearch-project/alerting#197

Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock merged commit 7959450 into opensearch-project:main Oct 7, 2021
@dblock dblock deleted the notification-jar-checksums branch October 7, 2021 00:02
dblock added a commit to opensearch-project/opensearch-build that referenced this pull request Oct 7, 2021
@dblock
Fixing maven artifacts for 1.1 (#703)
d4c7f3e 
* Removed scripts that were added into their respective repos.

See:

opensearch-project/common-utils#79
opensearch-project/common-utils#80
opensearch-project/job-scheduler#71
opensearch-project/job-scheduler#72

Signed-off-by: dblock <dblock@dblock.org>

* Removed PA and PA RCA from Maven publication.

Signed-off-by: dblock <dblock@dblock.org>

* Removed alerting that was moved to its repo.

opensearch-project/alerting#196
opensearch-project/alerting#197

Signed-off-by: dblock <dblock@dblock.org>
rishabhmaurya pushed a commit to rishabhmaurya/alerting-1 that referenced this pull request Nov 8, 2021
@dblock @rishabhmaurya
Publish notification JARs checksums. (opensearch-project#196)
0a45e50 
* Publish notification JARs checksums.

Signed-off-by: dblock <dblock@dblock.org>

* Remove sonatype staging.

Signed-off-by: dblock <dblock@dblock.org>
rishabhmaurya added a commit that referenced this pull request Nov 9, 2021
@rishabhmaurya @downsrob
@abbashus @dblock @mch2 @annie3431 @qreshi
Main -> 1.x merge (#228)
107d72a 
* Updates alerting version to 1.2 (#192)

* Updates alerting version to 1.2

* Adds snapshot repo to the repository file

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update build to use public Maven repo (#184)

Signed-off-by: Abbas Hussain <abbas_10690@yahoo.com>

* Publish notification JARs checksums. (#196)

* Publish notification JARs checksums.

Signed-off-by: dblock <dblock@dblock.org>

* Remove sonatype staging.

Signed-off-by: dblock <dblock@dblock.org>

* Updates testCompile mockito version to match OpenSearch changes (#204)

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update maven publication to include cksums. (#224)

This change adds a task to publish to a local staging repo under build/ that includes cksums.  It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add release notes for 1.2.0.0 release (#225)

* Create opensearch-alerting.release-notes-1.2.0.0.md

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Add backwards compatibility tests (#199)

* Initial commit for BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update bwc test to check Monitor stats and add bwc tests to GitHub Actions

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Use current version plugin bundle from build for bwc tests instead of manually uploading

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update mockito-core dependency to 3.12.4 to prevent conflict

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Remove disabling security manager flag when running BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

Co-authored-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
Co-authored-by: Abbas Hussain <abbashus@amazon.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com>
Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
rishabhmaurya added a commit that referenced this pull request Nov 9, 2021
@rishabhmaurya @qreshi
@skkosuri-amzn @downsrob @abbashus @dblock @mch2 @annie3431
Main->1.2 merge (#230)
43f1e31 
* Cherry-pick commits to 1.x (#227)

* Update copyright notice (#222)

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Admin Users must be able to access all monitors #139 (#220)

* Admin Users must be able to access all monitors #139

* Refactored

Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com>

* Updates alerting version to 1.2 (#192)

* Updates alerting version to 1.2

* Adds snapshot repo to the repository file

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update build to use public Maven repo (#184)

Signed-off-by: Abbas Hussain <abbas_10690@yahoo.com>

* Publish notification JARs checksums. (#196)

* Publish notification JARs checksums.

Signed-off-by: dblock <dblock@dblock.org>

* Remove sonatype staging.

Signed-off-by: dblock <dblock@dblock.org>

* Updates testCompile mockito version to match OpenSearch changes (#204)

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update maven publication to include cksums. (#224)

This change adds a task to publish to a local staging repo under build/ that includes cksums.  It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add release notes for 1.2.0.0 release (#225)

* Create opensearch-alerting.release-notes-1.2.0.0.md

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Add backwards compatibility tests (#199)

* Initial commit for BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update bwc test to check Monitor stats and add bwc tests to GitHub Actions

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Use current version plugin bundle from build for bwc tests instead of manually uploading

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update mockito-core dependency to 3.12.4 to prevent conflict

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Remove disabling security manager flag when running BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com>
Co-authored-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
Co-authored-by: Abbas Hussain <abbashus@amazon.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com>
AWSHurneyt pushed a commit to AWSHurneyt/OpenSearch-Alerting that referenced this pull request Mar 30, 2022
@rishabhmaurya @downsrob
@abbashus @dblock @mch2 @annie3431 @qreshi @AWSHurneyt
Main -> 1.x merge (opensearch-project#228)
7d06e50 
* Updates alerting version to 1.2 (opensearch-project#192)

* Updates alerting version to 1.2

* Adds snapshot repo to the repository file

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update build to use public Maven repo (opensearch-project#184)

Signed-off-by: Abbas Hussain <abbas_10690@yahoo.com>

* Publish notification JARs checksums. (opensearch-project#196)

* Publish notification JARs checksums.

Signed-off-by: dblock <dblock@dblock.org>

* Remove sonatype staging.

Signed-off-by: dblock <dblock@dblock.org>

* Updates testCompile mockito version to match OpenSearch changes (opensearch-project#204)

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update maven publication to include cksums. (opensearch-project#224)

This change adds a task to publish to a local staging repo under build/ that includes cksums.  It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add release notes for 1.2.0.0 release (opensearch-project#225)

* Create opensearch-alerting.release-notes-1.2.0.0.md

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Add backwards compatibility tests (opensearch-project#199)

* Initial commit for BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update bwc test to check Monitor stats and add bwc tests to GitHub Actions

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Use current version plugin bundle from build for bwc tests instead of manually uploading

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update mockito-core dependency to 3.12.4 to prevent conflict

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Remove disabling security manager flag when running BWC tests

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

Co-authored-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
Co-authored-by: Abbas Hussain <abbashus@amazon.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com>
Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saratvemulapalli saratvemulapalli saratvemulapalli approved these changes

@dbbaughe dbbaughe Awaiting requested review from dbbaughe

@peternied peternied Awaiting requested review from peternied

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dblock @codecov-commenter @saratvemulapalli