Bug fix for: Admin Users must be able to access all monitors #139 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityaj1107
approved these changes
Jan 14, 2022
| emptyMap(), | ||
| NStringEntity(search, ContentType.APPLICATION_JSON) | ||
| ) | ||
| assertEquals("Get monitor failed", RestStatus.OK, adminGetResponse.restStatus()) |
There was a problem hiding this comment.
Should we have a more descriptive error message?
There was a problem hiding this comment.
I think that is fine since its is part of the assertion failure which would mean the request failed to get the monitor
| @@ -509,6 +509,25 @@ class SecureMonitorRestApiIT : AlertingRestTestCase() { | |||
| ) | |||
| assertEquals("Search monitor failed", RestStatus.OK, adminSearchResponse.restStatus()) | |||
| assertEquals("Monitor not found during search", 1, getDocs(adminSearchResponse)) | |||
|
|
|||
| // get as "admin" - must get 1 docs | |||
| val id: String = monitorJson["_id"] as String | |||
There was a problem hiding this comment.
Add assertion check for ID?
lezzago
approved these changes
Jan 14, 2022
…rch-project#139 Signed-off-by: skkosuri-amzn <skkosuri@amazon.com>
skkosuri-amzn
force-pushed
the
sec-1.2-fix
branch
from
be6696e to
cb6f449
Compare
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
=========================================
Coverage 78.63% 78.63%
+ Complexity 218 217 -1
=========================================
Files 173 173
Lines 6968 6970 +2
Branches 915 916 +1
=========================================
+ Hits 5479 5481 +2
+ Misses 1002 1001 -1
- Partials 487 488 +1
Continue to review full report at Codecov.
|
lezzago
pushed a commit
to lezzago/alerting-opensearch
that referenced
this pull request
Mar 9, 2022
…rch-project#139 (opensearch-project#280) Signed-off-by: skkosuri-amzn <skkosuri@amazon.com>
lezzago
pushed a commit
to lezzago/alerting-opensearch
that referenced
this pull request
Mar 9, 2022
…rch-project#139 (opensearch-project#280) Signed-off-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com>
lezzago
pushed a commit
to lezzago/alerting-opensearch
that referenced
this pull request
Mar 9, 2022
…rch-project#139 (opensearch-project#280) Signed-off-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/OpenSearch-Alerting
that referenced
this pull request
Mar 30, 2022
…rch-project#139 (opensearch-project#280) Signed-off-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
qreshi
pushed a commit
that referenced
this pull request
Sep 23, 2022
qreshi
pushed a commit
that referenced
this pull request
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Bug fix for: Admin Users must be able to access all monitors #139
Description of changes:
Fix GET /monitor DELETE /monitor when
plugins.alerting.filter_by_backend_roles : trueCheckList:
[X] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.