-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose delete monitor api from alerting #568
Conversation
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 2.x #568 +/- ##
=========================================
Coverage 76.42% 76.43%
Complexity 116 116
=========================================
Files 143 141 -2
Lines 6969 6958 -11
Branches 973 973
=========================================
- Hits 5326 5318 -8
+ Misses 1150 1148 -2
+ Partials 493 492 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-568-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 61f93b449d35a43d1b0d87c3e1234ffb7f654157
# Push it to GitHub
git push --set-upstream origin backport/backport-568-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main Then, create a pull request where the |
* Added 2.1 release notes. (#485) (#487) * Added 2.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 9f3c393) Co-authored-by: AWSHurneyt <hurneyt@amazon.com> * Staging for version increment automation (#489) (#503) * Version increment automation Signed-off-by: pgodithi <pgodithi@amazon.com> * Version increment automation: task rename updateVersion Signed-off-by: pgodithi <pgodithi@amazon.com> (cherry picked from commit 3b8bfe7) Signed-off-by: prudhvigodithi <pgodithi@amazon.com> Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com> * Add support for reproducible builds (#472) (#499) As per gradle [docs] add support to remove timestamps and package with same order which is required from [reproducible] builds [docs]: https://docs.gradle.org/current/userguide/working_with_files.html#sec:archives [reproducible]: https://reproducible-builds.org/ Signed-off-by: Leonidas Spyropoulos <artafinde@archlinux.org> (cherry picked from commit a27d5a2) Signed-off-by: prudhvigodithi <pgodithi@amazon.com> Co-authored-by: Leonidas Spyropoulos <artafinde@gmail.com> * Refactored backwards compatibility tests to point to the OpenSearch 1.1.0.0 zip following deprecation of ODFE. (#510) (#512) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit fea6b4a) Co-authored-by: AWSHurneyt <hurneyt@amazon.com> * Bumping 2.x branch version from 2.1.0 to 2.2.0. Bumped mockito-core version from 4.3.1 to 4.6.1. (#506) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.2 release notes. (#514) * Added 2.2 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.2 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped 2.x branch from version 2.2.0 to 2.3.0. (#547) * Bumped 2.x branch from version 2.2.0 to 2.3.0. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped mockito core version. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Deprecate the Master nomenclature (#548) (#549) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Added 2.3 release notes. (#551) * Added 2.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * moving over data models from alerting to common-utils (#556) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * backport monitor datasources to 2.x (#558) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * expose delete monitor api from alerting (#568) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Use findings and alerts models, dtos from common utils (#569) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * Disable ktlint for alerting as it has errors on Windows (#570) (#571) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 3a844f8) Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> * Recreate request object from writeable for Get alerts and get findings (#577) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * Use alerting models and dtos from common-utils dependencies Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * port over datasources alert index usage correctly Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com> Co-authored-by: Leonidas Spyropoulos <artafinde@gmail.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Subhobrata Dey sbcd90@gmail.com
Issue #, if available:
Description of changes:
expose delete monitor api from alerting
CheckList:
[X] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.