Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.3] Disable ktlint for alerting as it has errors on Windows #572

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3a844f8 from #570

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 3a844f8)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team September 27, 2022 18:10
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #572 (5a7eef4) into 2.3 (34274a0) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.3     #572      +/-   ##
============================================
+ Coverage     76.75%   76.76%   +0.01%     
  Complexity      176      176              
============================================
  Files           166      166              
  Lines          8370     8370              
  Branches       1232     1232              
============================================
+ Hits           6424     6425       +1     
+ Misses         1342     1340       -2     
- Partials        604      605       +1     
Impacted Files Coverage Δ
...ing/model/destination/DestinationContextFactory.kt 75.00% <0.00%> (-3.58%) ⬇️
...ain/kotlin/org/opensearch/alerting/AlertService.kt 77.99% <0.00%> (-0.48%) ⬇️
...destinationmigration/DestinationConversionUtils.kt 71.11% <0.00%> (+1.11%) ⬆️
...nationmigration/DestinationMigrationCoordinator.kt 68.08% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon peterzhuamazon merged commit 4426bac into 2.3 Sep 27, 2022
@peterzhuamazon peterzhuamazon deleted the backport/backport-570-to-2.3 branch September 27, 2022 18:24
@peterzhuamazon peterzhuamazon self-assigned this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants