-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for windows ktlint issue #585
Conversation
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Thanks @sbcd90. Added 4 more backports to 2.x, 2.3, 1.x, 1.3. Thanks. |
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #585 +/- ##
============================================
- Coverage 76.85% 76.20% -0.66%
+ Complexity 178 116 -62
============================================
Files 167 124 -43
Lines 8556 6451 -2105
Branches 1268 942 -326
============================================
- Hits 6576 4916 -1660
+ Misses 1346 1052 -294
+ Partials 634 483 -151
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-585-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 49fbb4dd9cacc8355a23675e34eda49a0038384b
# Push it to GitHub
git push --set-upstream origin backport/backport-585-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-585-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 49fbb4dd9cacc8355a23675e34eda49a0038384b
# Push it to GitHub
git push --set-upstream origin backport/backport-585-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit 49fbb4d)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-585-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 49fbb4dd9cacc8355a23675e34eda49a0038384b
# Push it to GitHub
git push --set-upstream origin backport/backport-585-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3 Then, create a pull request where the |
…ject#624) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Subhobrata Dey sbcd90@gmail.com
Issue #, if available:
fix for windows ktlint issue
#573
#570
Description of changes:
fix for windows ktlint issue. tested this on windows server 2022 on ec2.
CheckList:
[X] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.