fix alias exists check in findings index creation #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
getsaurabh02
approved these changes
Oct 25, 2022
| @@ -326,7 +326,7 @@ class AlertIndices( | |||
| } | |||
| val findingsIndex = dataSources.findingsIndex | |||
| val findingsIndexPattern = dataSources.findingsIndexPattern ?: FINDING_HISTORY_INDEX_PATTERN | |||
| if (!clusterService.state().routingTable().hasIndex(findingsIndex)) { | |||
| if (!clusterService.state().metadata().hasAlias(findingsIndexPattern)) { | |||
There was a problem hiding this comment.
Should it be either of the index pattern or index name present?
sbcd90
approved these changes
Oct 25, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit ce79ffd)
sbcd90
pushed a commit
that referenced
this pull request
Oct 25, 2022
sbcd90
pushed a commit
to sbcd90/alerting
that referenced
this pull request
Nov 2, 2022
…#622) (opensearch-project#623) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
sbcd90
pushed a commit
that referenced
this pull request
Nov 2, 2022
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-622-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ce79ffd271f862d68f04f5c831da6271d55781b7
# Push it to GitHub
git push --set-upstream origin backport/backport-622-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Surya Sashank Nistala snistala@amazon.com