Ack alerts - allow moving alerts to history index with custom datasources #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
|
let's verify in integ test after acknowledging alert that we are moving the alerts to history index |
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep
approved these changes
Oct 28, 2022
sbcd90
approved these changes
Oct 28, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
…rces (#626) * in case of custom indices, allow moving alerts to history index Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> * empty commit Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> * added IT for custom datasources alert ack Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 0740d9b)
eirsep
pushed a commit
that referenced
this pull request
Oct 28, 2022
…rces (#626) (#627) * in case of custom indices, allow moving alerts to history index Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> * empty commit Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> * added IT for custom datasources alert ack Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 0740d9b) Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
sbcd90
pushed a commit
to sbcd90/alerting
that referenced
this pull request
Nov 2, 2022
…rces (opensearch-project#626) (opensearch-project#627) * in case of custom indices, allow moving alerts to history index Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> * empty commit Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> * added IT for custom datasources alert ack Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 0740d9b) Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
sbcd90
pushed a commit
that referenced
this pull request
Nov 2, 2022
…rces (#626) (#627) * in case of custom indices, allow moving alerts to history index Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> * empty commit Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> * added IT for custom datasources alert ack Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 0740d9b) Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petar Dzepina petar.dzepina@gmail.com
Issue #, if available:
Description of changes:
Ack alerts - allow moving alerts to history index with custom datasources
CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.