Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use notification snapshot for integ test #822

Merged

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Mar 2, 2023

Issue #, if available:
N/A
Description of changes:

  • Use notification snapshot for integ test
  • This improves stability for the tests when ci builds are not done.
    CheckList:
    [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #822 (b7ad445) into 2.x (ba54edd) will increase coverage by 0.11%.
The diff coverage is 66.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x     #822      +/-   ##
============================================
+ Coverage     75.49%   75.61%   +0.11%     
  Complexity      116      116              
============================================
  Files           125      125              
  Lines          6851     6868      +17     
  Branches       1028     1031       +3     
============================================
+ Hits           5172     5193      +21     
+ Misses         1156     1151       -5     
- Partials        523      524       +1     
Impacted Files Coverage Δ
...lin/org/opensearch/alerting/alerts/AlertIndices.kt 73.25% <0.00%> (-0.61%) ⬇️
.../alerting/transport/TransportIndexMonitorAction.kt 54.27% <0.00%> (ø)
...opensearch/alerting/util/DocLevelMonitorQueries.kt 72.24% <50.00%> (+0.55%) ⬆️
.../opensearch/alerting/DocumentLevelMonitorRunner.kt 80.27% <66.66%> (+0.54%) ⬆️
...n/kotlin/org/opensearch/alerting/AlertingPlugin.kt 93.75% <100.00%> (+0.03%) ⬆️
...ensearch/alerting/MonitorRunnerExecutionContext.kt 100.00% <100.00%> (ø)
...in/org/opensearch/alerting/MonitorRunnerService.kt 80.00% <100.00%> (+0.40%) ⬆️
.../kotlin/org/opensearch/alerting/util/IndexUtils.kt 76.27% <100.00%> (+5.43%) ⬆️
...ain/kotlin/org/opensearch/alerting/AlertService.kt 80.00% <0.00%> (+0.46%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lezzago lezzago marked this pull request as ready for review March 2, 2023 18:55
@lezzago lezzago requested a review from a team March 2, 2023 18:55
@Angie-Zhang Angie-Zhang merged commit fc1ecb0 into opensearch-project:2.x Mar 3, 2023
engechas pushed a commit to engechas/alerting that referenced this pull request Mar 13, 2024
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
engechas added a commit that referenced this pull request Mar 14, 2024
* use notiifcation snapshot for integ test (#822)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Fix build

Signed-off-by: Chase Engelbrecht <engechas@amazon.com>

* optimize doc-level monitor workflow for index patterns

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

* optimize doc-level monitor execution workflow for datastreams (#1302)

* optimize doc-level monitor execution for datastreams

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

* add more tests to address comments

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

* add integTest for multiple datastreams inside a single index pattern

* add integTest for multiple datastreams inside a single index pattern

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

---------

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

* Add jvm aware setting and max num docs settings for batching docs for percolate queries (#1435)

* add jvm aware and max docs settings for batching docs for percolate queries

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix stats logging

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* add queryfieldnames field in findings mapping

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* optimize to fetch only fields relevant to doc level queries in doc level monitor instead of entire _source for each doc (#1441)

* optimize to fetch only fields relevant to doc level queries in doc level monitor

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix test for settings check

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix ktlint

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* optimize sequence number calculation and reduce search requests in doc level monitor execution (#1445)

* optimize sequence number calculation and reduce search requests by n where n is number of shards being queried in the executino

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix tests

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* optimize check indices and execute to query only write index of aliases and datastreams during monitor creation

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix test

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* add javadoc

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* add tests to verify seq_no calculation

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* clean up doc level queries on dry run (#1430)

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Fix some tests from cherry-picks

Signed-off-by: Chase Engelbrecht <engechas@amazon.com>

---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
Co-authored-by: Joanne Wang <jowg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants