-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix schema version in tests and delegate monitor metadata construction in tests #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep
requested review from
lezzago,
AWSHurneyt,
sbcd90,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
June 1, 2023 21:25
42 tasks
…adata verification Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep
changed the title
fix schema version in tests for findings and scheduled jobs index mappings
fix schema version in tests and delegate monitor metadata construction in tests
Jun 1, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #948 +/- ##
============================================
- Coverage 76.07% 74.74% -1.34%
- Complexity 110 111 +1
============================================
Files 125 141 +16
Lines 7065 8263 +1198
Branches 1052 1206 +154
============================================
+ Hits 5375 6176 +801
- Misses 1153 1474 +321
- Partials 537 613 +76
|
lezzago
approved these changes
Jun 2, 2023
getsaurabh02
approved these changes
Jun 2, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
…n in tests (#948) * fix schema version in tests for findings and scheduled jobs index mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix workflow delegate monitor metadata construction in tests with metadata verification Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * unify all workflow transport tests Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * unify all single node tests into one single class Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 32c0bb0)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
…n in tests (#948) * fix schema version in tests for findings and scheduled jobs index mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix workflow delegate monitor metadata construction in tests with metadata verification Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * unify all workflow transport tests Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * unify all single node tests into one single class Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 32c0bb0)
eirsep
added a commit
that referenced
this pull request
Jun 2, 2023
…n in tests (#948) (#952) * fix schema version in tests for findings and scheduled jobs index mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix workflow delegate monitor metadata construction in tests with metadata verification Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * unify all workflow transport tests Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * unify all single node tests into one single class Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 32c0bb0) Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep
added a commit
that referenced
this pull request
Jun 2, 2023
…n in tests (#948) (#951) * fix schema version in tests for findings and scheduled jobs index mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix workflow delegate monitor metadata construction in tests with metadata verification Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * unify all workflow transport tests Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * unify all single node tests into one single class Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 32c0bb0) Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unify single node tests verifying workflow behaviour into one single class
Tests verifying schema versions need to be updated as mappings for scheduled jobs and findings have been updated.
this PR is to fix schema version in tests for findings and scheduled jobs index mappings
Delegate monitor metadata verification fixed to assert the right metadata id.