Skip to content

Commit

Permalink
Merge branch 'main' into sync-main
Browse files Browse the repository at this point in the history
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
  • Loading branch information
amitgalitz committed May 31, 2023
2 parents 9308a4c + 93ba127 commit ab3aef3
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 8 deletions.
3 changes: 1 addition & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
# This should match the owning team set up in https://github.com/orgs/opensearch-project/teams
* @opensearch-project/anomaly-detection
* @ohltyler @kaituo @jackiehanyang @amitgalitz @sean-zheng-amazon
15 changes: 12 additions & 3 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,18 @@ This document contains a list of maintainers in this repo. See [opensearch-proje

## Current Maintainers

| Maintainer | GitHub ID | Affiliation |
| ----------------------- | ------------------------------------------------------- | ----------- |
| Tyler Ohlsen | [ohltyler](https://github.com/ohltyler) | Amazon |
| Maintainer | GitHub ID | Affiliation |
| ----------------------- | -------------------------------------------------------- | ----------- |
| Tyler Ohlsen | [ohltyler](https://github.com/ohltyler) | Amazon |
| Kaituo Li | [kaituo](https://github.com/kaituo) | Amazon |
| Jackie Han | [jackiehanyang](https://github.com/jackiehanyang) | Amazon |
| Amit Galitzky | [amitgalitz](https://github.com/amitgalitz) | Amazon |
| Sean Zheng | [sean-zheng-amazon](https://github.com/sean-zheng-amazon)| Amazon |

## Emeritus Maintainers

| Maintainer | GitHub ID | Affiliation |
| ----------------- | ------------------------------------------------------- | ----------- |
| Yaliang | [ylwu-amzn](https://github.com/ylwu-amzn) | Amazon |
| Yizhe Liu | [yizheliu-amazon](https://github.com/yizheliu-amazon) | Amazon |
| Vijayan Balasubramanian | [VijayanB](https://github.com/VijayanB) | Amazon |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,14 @@ describe('<NameAndDescription /> spec', () => {
expect(container.firstChild).toMatchSnapshot();
});
test('shows error for detector name input when toggling focus/blur', async () => {
const handleValidateName = jest.fn().mockImplementation(() => {
throw 'Required';
const handleValidateName = jest.fn().mockImplementationOnce(() => {
return 'Required';
});
const { queryByText, findByText, getByPlaceholderText } = render(
<Formik initialValues={{ name: '' }} onSubmit={jest.fn()}>
<Formik
initialValues={{ name: '', description: 'one' }}
onSubmit={jest.fn()}
>
{() => (
<div>
<NameAndDescription onValidateDetectorName={handleValidateName} />
Expand All @@ -49,6 +52,7 @@ describe('<NameAndDescription /> spec', () => {
expect(handleValidateName).toHaveBeenCalledTimes(1);
expect(findByText('Required')).not.toBeNull();
});

test('shows error for detector description input when toggling focus/bur', async () => {
const { queryByText, findByText, getByPlaceholderText } = render(
<Formik
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
## Version 2.7.0.0 Release Notes

Compatible with OpenSearch Dashboards 2.7.0

### Enhancements

* Run prettier command against all files ([#444](https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/pull/444))

0 comments on commit ab3aef3

Please sign in to comment.