Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore rules comparing actual and expected values #859

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

kaituo
Copy link
Collaborator

@kaituo kaituo commented Sep 1, 2024

Description

This PR introduces suppression anomaly rules under the Advanced Settings section, enabling users to suppress anomalies based on the difference between expected and actual values, either as an absolute value or a relative percentage.

Testing:

  • Added unit tests to verify the suppression rules functionality.
  • Conducted manual end-to-end (e2e) tests to validate the implementation.

Note most of changes are snapshot file changes:

git diff 3ed0058a9c8b52dc8a34b11f4869f0dda6904e2a --stat -- '*.snap'
 .../containers/__tests__/__snapshots__/DetectorConfig.test.tsx.snap | 1563 +++++++++++++++++++++++++++++-
 .../__tests__/__snapshots__/AdditionalSettings.test.tsx.snap        |  824 ++++++++++------
 .../__tests__/__snapshots__/ModelConfigurationFields.test.tsx.snap  |  413 +++++---
 .../__tests__/__snapshots__/ReviewAndCreate.test.tsx.snap           |  802 +++++++++------
 4 files changed, 2814 insertions(+), 788 deletions(-)

demo:

rule.mov

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kaituo
Copy link
Collaborator Author

kaituo commented Sep 1, 2024

"Run binary installation" failed due to opensearch-project/security-dashboards-plugin#2118

This PR introduces suppression anomaly rules under the Advanced Settings section, enabling users to suppress anomalies based on the difference between expected and actual values, either as an absolute value or a relative percentage.

Testing:
* Added unit tests to verify the suppression rules functionality.
* Conducted manual end-to-end (e2e) tests to validate the implementation.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
@kaituo kaituo merged commit 9874c48 into opensearch-project:main Sep 3, 2024
7 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
This PR introduces suppression anomaly rules under the Advanced Settings section, enabling users to suppress anomalies based on the difference between expected and actual values, either as an absolute value or a relative percentage.

Testing:
* Added unit tests to verify the suppression rules functionality.
* Conducted manual end-to-end (e2e) tests to validate the implementation.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
(cherry picked from commit 9874c48)
jackiehanyang pushed a commit that referenced this pull request Sep 3, 2024
This PR introduces suppression anomaly rules under the Advanced Settings section, enabling users to suppress anomalies based on the difference between expected and actual values, either as an absolute value or a relative percentage.

Testing:
* Added unit tests to verify the suppression rules functionality.
* Conducted manual end-to-end (e2e) tests to validate the implementation.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
(cherry picked from commit 9874c48)

Co-authored-by: Kaituo Li <kaituo@amazon.com>
kaituo added a commit to kaituo/anomaly-detection-dashboards-plugin that referenced this pull request Sep 10, 2024
…t#859) (opensearch-project#860)

This PR introduces suppression anomaly rules under the Advanced Settings section, enabling users to suppress anomalies based on the difference between expected and actual values, either as an absolute value or a relative percentage.

Testing:
* Added unit tests to verify the suppression rules functionality.
* Conducted manual end-to-end (e2e) tests to validate the implementation.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
(cherry picked from commit 9874c48)

Co-authored-by: Kaituo Li <kaituo@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x github actions Updating or adding GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants