Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show suggestAD action if the data source has no AI agent #901

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Do not show suggestAD action if the data source has no AI agent #901

merged 1 commit into from
Oct 22, 2024

Conversation

gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Oct 21, 2024 •
edited
Loading

Description

This PR adds some small enhancements and fixes some bugs for the suggestAD feature, which contains:

  1. Do not show the suggestAD action button if the data source of the selected index pattern has no AI agent.
  2. If the selected index pattern doesn't have time field, then we use the root level date type field as the default timestamp field.
  3. If cannot find any date type field from the mappings of the selected index pattern, then pops up an error.
  4. Feature name cannot be longer than 64, so we truncate the feature name if it exceeds the limit.

Issues Resolved

#816

AD.mov

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaobinlong
Copy link
Contributor Author

@jackiehanyang could you help to review this PR, thanks!

@gaobinlong
Do not show suggestAD action if the data source has no AI agent
0d994f5 
Signed-off-by: gaobinlong <gbinlong@amazon.com>

Signed-off-by: gaobinlong <gbinlong@amazon.com>
@kaituo kaituo merged commit 7b60fed into opensearch-project:main Oct 22, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 22, 2024
@gaobinlong @github-actions
Do not show suggestAD action if the data source has no AI agent (#901)
709c44f 
Signed-off-by: gaobinlong <gbinlong@amazon.com>
(cherry picked from commit 7b60fed)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 22, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
@gaobinlong @github-actions
Do not show suggestAD action if the data source has no AI agent (#901)
16588d1 
Signed-off-by: gaobinlong <gbinlong@amazon.com>
(cherry picked from commit 7b60fed)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 23, 2024
Merged
kaituo pushed a commit that referenced this pull request Oct 23, 2024
@opensearch-trigger-bot @gaobinlong
Do not show suggestAD action if the data source has no AI agent (#901) (
1e31334 
#905)

Signed-off-by: gaobinlong <gbinlong@amazon.com>
(cherry picked from commit 7b60fed)

Co-authored-by: gaobinlong <gbinlong@amazon.com>
kaituo pushed a commit that referenced this pull request Oct 23, 2024
@opensearch-trigger-bot @gaobinlong
Do not show suggestAD action if the data source has no AI agent (#901) (
1a90032 
#906)

Signed-off-by: gaobinlong <gbinlong@amazon.com>
(cherry picked from commit 7b60fed)

Co-authored-by: gaobinlong <gbinlong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaituo kaituo kaituo approved these changes

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaobinlong @kaituo