[2.x] Fix TransportService constructor due to changes in core plus guava bump #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
|
Every test except |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
ohltyler
previously approved these changes
Oct 5, 2023
|
Shouldn't we get this change on main and then backport to 2.x? |
|
I usually agree its just that main is pretty broken right now with other things so I am trying to get it fixed on 2.x and 2.11 first then I can forward port this change |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
71 tasks
ohltyler
previously approved these changes
Oct 5, 2023
amitgalitz
changed the title
owaiskazi19
previously approved these changes
Oct 5, 2023
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
owaiskazi19
approved these changes
Oct 5, 2023
joshpalis
approved these changes
Oct 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
…ava bump (#1069) * adjust transportService constructor due to changes in core Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * updated guava and fixed another compile issue Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * fixed mocking of transport service Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * adding 2.11 release notes Signed-off-by: Amit Galitzky <amgalitz@amazon.com> --------- Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit f81b75d)
ohltyler
pushed a commit
that referenced
this pull request
Oct 5, 2023
…ava bump (#1069) (#1070) * adjust transportService constructor due to changes in core Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * updated guava and fixed another compile issue Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * fixed mocking of transport service Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * adding 2.11 release notes Signed-off-by: Amit Galitzky <amgalitz@amazon.com> --------- Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit f81b75d) Co-authored-by: Amit Galitzky <amgalitz@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a tracer field for the TransportService constructor in our test cases
Core change to add tracer in MockNioTransport https://github.com/opensearch-project/OpenSearch/pull/10143/files#diff-f37f7447c76ba79901c3298a1addce39d103ce72efc5a75a1f7602a4e2829b62R115
core changes to add tracker in TransportService opensearch-project/OpenSearch@27cddec
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.