Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Refactor client's getDetectorProfile to use GetAnomalyDetectorTransportAction (#1124) #1125

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

ohltyler
Copy link
Member

Description

Manual backport of #1124. Needed due to import refactoring done on 3.x.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…rtAction (opensearch-project#1124)

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (4e6ca48) 79.68% compared to head (9281491) 79.67%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1125      +/-   ##
============================================
- Coverage     79.68%   79.67%   -0.02%     
- Complexity     4353     4357       +4     
============================================
  Files           309      309              
  Lines         18202    18207       +5     
  Branches       1909     1909              
============================================
+ Hits          14505    14506       +1     
- Misses         2788     2790       +2     
- Partials        909      911       +2     
Flag Coverage Δ
plugin 79.67% <56.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...g/opensearch/ad/client/AnomalyDetectionClient.java 100.00% <100.00%> (ø)
...ensearch/ad/client/AnomalyDetectionNodeClient.java 100.00% <100.00%> (ø)
...earch/ad/transport/GetAnomalyDetectorResponse.java 81.30% <12.50%> (-5.57%) ⬇️

... and 6 files with indirect coverage changes

@ohltyler ohltyler merged commit 871b1dd into opensearch-project:2.x Dec 28, 2023
18 of 19 checks passed
@ohltyler ohltyler deleted the profile-refactor-2x branch December 28, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants