Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed additional non-inclusive terms #644

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

amitgalitz
Copy link
Member

Signed-off-by: Amit Galitzky amgalitz@amazon.com

Description

This PR removes additional uses of the term "master" from the code. Additional removals will occur after more updates are made on OS core.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@amitgalitz amitgalitz requested a review from a team August 26, 2022 20:23
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #644 (348b5cb) into main (c92cdc8) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #644      +/-   ##
============================================
- Coverage     79.12%   79.05%   -0.08%     
+ Complexity     4251     4242       -9     
============================================
  Files           301      301              
  Lines         17872    17872              
  Branches       1897     1897              
============================================
- Hits          14142    14129      -13     
- Misses         2831     2839       +8     
- Partials        899      904       +5     
Flag Coverage Δ
plugin 79.05% <66.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...opensearch/ad/indices/AnomalyDetectionIndices.java 72.12% <50.00%> (ø)
...search/ad/cluster/ClusterManagerEventListener.java 78.72% <100.00%> (ø)
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 81.76% <0.00%> (-3.96%) ⬇️
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 90.12% <0.00%> (-2.47%) ⬇️
.../main/java/org/opensearch/ad/ml/CheckpointDao.java 69.74% <0.00%> (-0.64%) ⬇️
...rch/ad/transport/AnomalyResultTransportAction.java 80.87% <0.00%> (+0.69%) ⬆️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 76.90% <0.00%> (+0.75%) ⬆️
...rch/ad/transport/ForwardADTaskTransportAction.java 97.45% <0.00%> (+3.38%) ⬆️

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amitgalitz amitgalitz merged commit 884573f into opensearch-project:main Sep 7, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2022
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
(cherry picked from commit 884573f)
@ohltyler ohltyler mentioned this pull request Sep 7, 2022
4 tasks
ohltyler pushed a commit that referenced this pull request Sep 7, 2022
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
(cherry picked from commit 884573f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants