Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/extensions] Removed BWC code for 1.0 version #727

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Nov 14, 2022

Description

Core removed 1x bwc version resulting in build failure for AD Extension opensearch-project/OpenSearch#5021. AD plugin did the work here for the same: #714

Issues Resolved

Closes opensearch-project/opensearch-sdk-java#242

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@owaiskazi19 owaiskazi19 requested a review from a team November 14, 2022 19:18
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owaiskazi19 Was this a cherry-pick of the #714 code?

@owaiskazi19
Copy link
Member Author

owaiskazi19 commented Nov 14, 2022

@owaiskazi19 Was this a cherry-pick of the #714 code?

Kinda, with few tweaks based on AD Extension but mostly yes

@owaiskazi19 owaiskazi19 merged commit 21c92c9 into opensearch-project:feature/extensions Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants