[Extensions] Migrate ADResultBulkAction/TransportAction and Multi-Entity real time analysis #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents for ADResultAction, EntityResultAction, RCFResultAction. Uncomments JS dependent code Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
… for HCAD. Preparational work for HCAD results, invokes EntityResultAction in pagelistener Signed-off-by: Joshua Palis <jpalis@amazon.com>
… found message rather than catching OpenSearchStatusException Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
…Util and opting to use sdkRestClient.bulk() instead Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
owaiskazi19
changed the title
owaiskazi19
reviewed
Apr 24, 2023
|
|
||
| if (bulkResponse.errors()) { | ||
| StringBuilder sb = new StringBuilder(); | ||
| sb.append("failure in bulk execution:"); |
There was a problem hiding this comment.
Suggested change
| sb.append("failure in bulk execution:"); | |
| sb.append("Failed to prepare request to bulk index anomaly results:"); |
| ImmutableOpenMap<String, IndexMetadata> immutableOpenMap = ImmutableOpenMap | ||
| .<String, IndexMetadata>builder() | ||
| .fPut( | ||
| Map<String, IndexMetadata> immutableOpenMap = new HashMap<>(); |
There was a problem hiding this comment.
I see the change is coming from OpenSearch but we shouldn't call the variable name as immutableOpenMap anymore. How about indexMap or if you have a better name?
There was a problem hiding this comment.
indexMap sounds good, Ill go ahead and change this
Signed-off-by: Joshua Palis <jpalis@amazon.com>
owaiskazi19
approved these changes
Apr 24, 2023
|
@joshpalis build failed. Can you look into it? |
2 tasks
|
@owaiskazi19 yes I just need to fix the failing test classes |
dbwiddis
approved these changes
Apr 24, 2023
|
LGTM other than the failing tests. |
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates HCAD realtime analysis
Issues Resolved
opensearch-project/opensearch-sdk-java#684
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.