Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] common utils to support Microsoft teams in notifications #512

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bae1bee from #428.

* Added common utils for microsoft teams

Signed-off-by: danielkyalo599 <johbiento@gmail.com>

* Added configType ,eventstatus,configDataProperties and msTeams files

Signed-off-by: dankyalo599 <johbiento@gmail.com>

* Added ConfigType,EventStatus,ConfigDataProperties and MicrosoftTeams

Signed-off-by: dankyalo599 <johbiento@gmail.com>

* fix build

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* fix build, add more test

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* change strings import

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

* fix after core

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

---------

Signed-off-by: danielkyalo599 <johbiento@gmail.com>
Signed-off-by: dankyalo599 <johbiento@gmail.com>
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Co-authored-by: danielkyalo599 <johbiento@gmail.com>
(cherry picked from commit bae1bee)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #512 (adcb8f5) into 2.x (7e1e226) will increase coverage by 0.13%.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##                2.x     #512      +/-   ##
============================================
+ Coverage     72.84%   72.97%   +0.13%     
- Complexity      835      844       +9     
============================================
  Files           129      130       +1     
  Lines          5586     5621      +35     
  Branches        683      688       +5     
============================================
+ Hits           4069     4102      +33     
  Misses         1215     1215              
- Partials        302      304       +2     
Files Changed Coverage Δ
...nsearch/commons/notifications/model/EventStatus.kt 81.15% <0.00%> (-1.20%) ⬇️
...arch/commons/notifications/model/MicrosoftTeams.kt 96.66% <96.66%> (ø)
...ensearch/commons/notifications/model/ConfigType.kt 100.00% <100.00%> (ø)
...notifications/model/config/ConfigDataProperties.kt 77.77% <100.00%> (+1.77%) ⬆️

@bowenlan-amzn bowenlan-amzn merged commit e6783b6 into 2.x Aug 18, 2023
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…project#428) (opensearch-project#512)

* Added common utils for microsoft teams



* Added configType ,eventstatus,configDataProperties and msTeams files



* Added ConfigType,EventStatus,ConfigDataProperties and MicrosoftTeams



* fix build



* fix build, add more test



* change strings import



* fix after core



---------





(cherry picked from commit bae1bee)

Signed-off-by: danielkyalo599 <johbiento@gmail.com>
Signed-off-by: dankyalo599 <johbiento@gmail.com>
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: danielkyalo599 <johbiento@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants