Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'fields' parameter in doc level query object. #546

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Oct 7, 2023

Description

Query string query supports fields parameter in percolate queries.
https://opensearch.org/docs/latest/query-dsl/full-text/query-string/#parameters
to support queries with multiple fields or wildcards in percolate query.

This enabled queries like

GET /_search
{
  "query": {
    "query_string": {
      "fields": [ "name", "description" ],
      "query": "apple AND tree"
    }
  }
}

Issues Resolved

[BUG] Unable to create doc level monitor when passing wildcard field names in query string query

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #546 (9ee4c58) into main (1b98f03) will decrease coverage by 0.09%.
The diff coverage is 30.76%.

@@             Coverage Diff              @@
##               main     #546      +/-   ##
============================================
- Coverage     74.64%   74.55%   -0.09%     
  Complexity      872      872              
============================================
  Files           130      130              
  Lines          5667     5680      +13     
  Branches        697      698       +1     
============================================
+ Hits           4230     4235       +5     
- Misses         1130     1139       +9     
+ Partials        307      306       -1     
Files Coverage Δ
...opensearch/commons/alerting/model/DocLevelQuery.kt 53.94% <30.76%> (-4.79%) ⬇️

... and 1 file with indirect coverage changes

@eirsep eirsep merged commit 2ef47f9 into opensearch-project:main Oct 7, 2023
7 of 8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 14, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 2ef47f9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 14, 2023
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 2ef47f9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep pushed a commit that referenced this pull request Oct 19, 2023
(cherry picked from commit 2ef47f9)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep pushed a commit that referenced this pull request Oct 19, 2023
(cherry picked from commit 2ef47f9)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep added a commit to eirsep/common-utils that referenced this pull request Nov 27, 2023
eirsep added a commit to eirsep/common-utils that referenced this pull request Nov 27, 2023
…-project#546) (opensearch-project#551)"

This reverts commit d92419d.

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep added a commit that referenced this pull request Nov 27, 2023
* Revert "add fields param in toxcontent() for doc level query (#549) (#555)"

This reverts commit dcf288d.

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* Revert "add 'fields' parameter in doc level query object. (#546) (#551)"

This reverts commit d92419d.

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…#546) (opensearch-project#550)

(cherry picked from commit 2ef47f9)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants